X Tutup
Skip to content

chore(script): publish angular 1 router to latest tag in npm#7408

Closed
btford wants to merge 3 commits intoangular:masterfrom
btford:chore-angular1-router-script
Closed

chore(script): publish angular 1 router to latest tag in npm#7408
btford wants to merge 3 commits intoangular:masterfrom
btford:chore-angular1-router-script

Conversation

@btford
Copy link
Copy Markdown
Contributor

@btford btford commented Mar 3, 2016

@btford btford added pr_state: LGTM action: merge The PR is ready for merge by the caretaker labels Mar 14, 2016
@evmar
Copy link
Copy Markdown
Contributor

evmar commented Mar 14, 2016

I believe this should be safe for google3 without testing, speak now if you believe otherwise. :)

@mary-poppins
Copy link
Copy Markdown

mary-poppins commented Mar 14, 2016

Merging PR #7408 on behalf of @martine to branch presubmit-martine-pr-7408.

@evmar evmar added action: merge The PR is ready for merge by the caretaker zomg_admin: do merge and removed action: merge The PR is ready for merge by the caretaker labels Mar 14, 2016
@mary-poppins
Copy link
Copy Markdown

mary-poppins commented Mar 15, 2016

Merging PR #7408 on behalf of @martine to branch presubmit-martine-pr-7408.

@evmar
Copy link
Copy Markdown
Contributor

evmar commented Mar 15, 2016

Actually, this branch now has more commits than when I started on it, and it fails on travis:
https://travis-ci.org/angular/angular/builds/116191773

@evmar evmar removed the action: merge The PR is ready for merge by the caretaker label Mar 15, 2016
@btford btford force-pushed the chore-angular1-router-script branch from deeb52b to 4b5a493 Compare March 21, 2016 23:45
@btford
Copy link
Copy Markdown
Contributor Author

btford commented Mar 21, 2016

Rebased– should be good to merge now

@btford btford added the action: merge The PR is ready for merge by the caretaker label Mar 21, 2016
@mary-poppins
Copy link
Copy Markdown

mary-poppins commented Mar 22, 2016

Merging PR #7408 on behalf of @jelbourn to branch presubmit-jelbourn-pr-7408.

@mhevery mhevery closed this in 5c330ea Mar 22, 2016
@angular-automatic-lock-bot
Copy link
Copy Markdown

angular-automatic-lock-bot bot commented Sep 8, 2019

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

action: merge The PR is ready for merge by the caretaker cla: yes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@btford @evmar @mary-poppins @jelbourn @googlebot
X Tutup