fix(dart/payload): Fix runtime error in hello_world payload app#7358
Closed
kegluneq wants to merge 1 commit intoangular:masterfrom
Closed
fix(dart/payload): Fix runtime error in hello_world payload app#7358kegluneq wants to merge 1 commit intoangular:masterfrom
kegluneq wants to merge 1 commit intoangular:masterfrom
Conversation
The hello_world app used to measure Dart payload size was broken by a change in angular@7ae23ad. This breakage does not materially affect the size of the generated code, (before fix: 298819, after fix: 298825), and since it was a runtime error it was not noticed & not a problem. Update the app to work again.
kegluneq
added
type: bug/fix
comp: dart-transformer
action: review
tbosch
added
pr_state: LGTM
and removed
action: review
Author
|
cc: @jakemac53 |
|
Merging PR #7358 on behalf of @vsavkin to branch presubmit-vsavkin-pr-7358. |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The hello_world app used to measure Dart payload size was broken by a
change in
7ae23ad.
This breakage does not materially affect the size of the generated code,
(before fix: 298819, after fix: 298825), and since it was a runtime
error it was not noticed & not a problem.
Update the app to work again.