Closed
Conversation
mhevery
force-pushed
the
ngClassCleanup
branch
4 times, most recently
from
63baac1 to
5fbd253
Compare
Contributor
Author
|
@juliemr / @jelbourn can you help me debug https://travis-ci.org/angular/angular/jobs/110646029#L1275 There is an end 2 end test failing and I am not sure as to why. (Ignore the first SHA, it passes here: https://travis-ci.org/angular/angular/builds/110551804) The only relevant change is ngClass file here: mhevery@5fbd253#diff-2d9cd73c23ec9bc747111f8bf4caed4bL1 |
mhevery
force-pushed
the
ngClassCleanup
branch
from
5fbd253 to
cf8736c
Compare
Contributor
Author
mhevery
force-pushed
the
ngClassCleanup
branch
from
cf8736c to
d7c1a2a
Compare
Contributor
Author
|
@vsavkin please review. |
mhevery
force-pushed
the
ngClassCleanup
branch
from
d7c1a2a to
9e6b4bb
Compare
Contributor
Author
|
@vsavkin LGTMed |
mhevery
added
pr_state: LGTM
action: merge
Contributor
|
TAP Green |
|
Merging PR #7202 on behalf of @vikerman to branch presubmit-vikerman-pr-7202. |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ignore noImplicitAny changes they will be merged with #7030 and are all green. The failure seems to come from the
ng_class.tschanges, but I don't see a reason why.