Closed
Conversation
mhevery
force-pushed
the
ddc
branch
20 times, most recently
from
67897ac to
2dcf8c5
Compare
4 tasks
mhevery
force-pushed
the
ddc
branch
7 times, most recently
from
1db66ed to
a929919
Compare
Contributor
There was a problem hiding this comment.
Does unimplemented just throw? If so, perhaps just call it instead of returning it? Then you would not need a cast.
Alternatively, declaring it generic should work:
/*=T*/ unimplemented/*<T>*/() { throw "not implemented"; }
Contributor
|
lgtm other than comments above |
mhevery
added
pr_state: LGTM
action: merge
mhevery
force-pushed
the
ddc
branch
2 times, most recently
from
420ceb1 to
dce7202
Compare
Contributor
mhevery
force-pushed
the
ddc
branch
3 times, most recently
from
18cdfc9 to
8fbf418
Compare
|
Merging PR #7195 on behalf of @vikerman to branch presubmit-vikerman-pr-7195. |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
chore: fix DDC errors / warnings