Handle unrecognized instructions in router#7183
Handle unrecognized instructions in router#7183tiziano88 wants to merge 1 commit intoangular:masterfrom tiziano88:patch-1
Conversation
This is currently throwing a null error when the instruction is not recognized by the router, and AFAICT there is no way to catch that.
|
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed, please reply here (e.g.
|
| this.navigateByInstruction(instruction, isPresent(change['pop'])) | ||
| .then((_) => { | ||
| // Instruction was not recognized, return immediately. | ||
| if (instruction == null) { |
There was a problem hiding this comment.
Why not putting this check between line 432 and 433? And also use isBlank.
|
Closing this in favour of #7203, since GitHub does not allow me to change the email address attached to a commit done via its UI, and I'm not sure @googlebot will notice the change anyway. |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
3 participants
This is currently throwing a null error when the instruction is not recognized by the router, and AFAICT there is no way to catch that.