chore(test): migrate Dart tests to package:test by juliemr · Pull Request #7111 · angular/angular

juliemr · 2016-02-16T22:37:47Z

Instead of running with karma and the karma-dart shim, run dart
tests directly using the new package:test runner. This migrates
away from package:unittest.

Fixes a couple tests, mostly associated with depending on absolute
URLs or editing the test providers after an injector had already
been created.

Remove karma-dart and associated files. Change gupfiles to run tests
via pub run test instead.

juliemr · 2016-02-16T23:03:42Z

FYI folks interesting in dart test: @kevmoo @nex3 @kegluneq

juliemr · 2016-02-16T23:11:22Z

Transformer tests are failing but will pass after #6896 is merged.

juliemr · 2016-02-16T23:20:37Z

@vicb do you have time to review this?

vicb · 2016-02-17T18:45:10Z

gulpfile.js

is this expected to remove build.dart.material.css ?

Yes - @jelbourn said that we don't care about the material tests anymore, so to speed things up it should be OK to remove this.

vicb · 2016-02-17T19:15:37Z

@juliemr most of the changes look good to me. However there are some Travis errors, are those expected ?

juliemr · 2016-02-17T19:16:06Z

The dev.js travis error is occuring for all PRs, as far as I can tell. The Transformer tests are failing but will pass after #6896 is merged (we should merge that first and then I'll verify).

juliemr · 2016-03-01T21:54:00Z

I've rebased on top of the transformer tests, which are now in.

juliemr · 2016-03-03T07:12:21Z

Sigh. OK, so here's the current status - the test.server.dart gulp task is failing on Travis but not on my local machine. It looks like the problem is that I had to update the version of the pub package webdriver that we depend on (because the old one explicitly depending on a conflicting version of package test, I think), and the newer webdriver can't use Dartium because the chrome-version of Dartium is very old. Now I'm trying to use normal Chrome on Travis, but it times out for unknown reasons.

Versions are hard :(

juliemr · 2016-03-03T07:40:14Z

Precisely - the pub spec incompatibility is:

webdriver: ^0.9.0 depends on matcher: ^0.11.4. This is an older version of matcher which is tied to versions of test: <0.12.0.

juliemr · 2016-03-03T08:24:08Z

Found a workaround! @vicb would you mind taking another look, and then I'll squash the commits?

zoechi · 2016-03-03T09:32:17Z

Why are you using WebDriver 0.9.x instead of 1.0.x? matcher: '^0.12.0+1'

zoechi · 2016-03-03T18:11:51Z

There is webdriver: '^0.9.0 in dependencies in modules/benchpress/pubspec.yaml which means >=0.9.0 <0.10.0. For versions < 1.0.0 ^ means include all versions with the same minor version. For versions > 1.0.0 it means include all versions with the same major version. Therefore if you update the webdriver dependency to webdriver: '^1.0.0, you shouldn't need the overrides and you'd get the newest webdriver.

juliemr · 2016-03-03T18:13:27Z

@zoechi but we can't use the newest webdriver, because it's incompatible with Dartium.

zoechi · 2016-03-03T18:17:36Z

I see, didn't know that. That's why I asked "why you are 0.9.x instead of 1.0.x". Sorry for the noise.

juliemr · 2016-03-03T18:38:41Z

I made a separate issue for upgrading benchpress's webdriver: #7404

IgorMinar · 2016-03-03T19:18:20Z

modules/angular2/test/core/dom/dom_adapter_spec.ts

does the test runner mess with the url?

Yes - it adds the dart test runner's test tmp directory in front of it.

mary-poppins · 2016-03-03T23:00:42Z

Merging PR #7111 on behalf of @vikerman to branch presubmit-vikerman-pr-7111.

kevmoo · 2016-03-03T23:07:12Z

@IgorMinar @juliemr FYI – I think we could/should remove unittest from the root pubspec – it doesn't appear to be used anywhere now...

juliemr · 2016-03-03T23:09:17Z

@kevmoo it is still used by some transformer tests.

kevmoo · 2016-03-03T23:10:59Z

@kevmoo it is still used by some transformer tests.

@juliemr Yes, but from within the package. Actually, I don't see any need for anything but the 'guiness2' package in the root pubpsec.yaml file

juliemr · 2016-03-03T23:22:04Z

Due to the way that the build steps copy the pubspecs around (which I admit, I do not fully understand) that didn't work.

Instead of running with karma and the karma-dart shim, run dart tests directly using the new package:test runner. This migrates away from package:unittest. Fixes a couple tests, mostly associated with depending on absolute URLs or editing the test providers after an injector had already been created. Remove karma-dart and associated files. Change gupfiles to run tests via `pub run test` instead.

vikerman · 2016-03-04T05:06:37Z

Merged to master manually

angular-automatic-lock-bot · 2019-09-08T02:21:49Z

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

_{This action has been performed automatically by a bot.}

juliemr added type: chore action: review The PR is still awaiting reviews from at least one requested reviewer labels Feb 16, 2016

juliemr self-assigned this Feb 16, 2016

googlebot added the cla: yes label Feb 16, 2016

This was referenced Feb 16, 2016

WIP DO NOT SUBMIT - Migrate Dart tests to package:test #7042

Closed

chore(test): move to using dart:test for dart unit tests #3258

Closed

juliemr assigned vicb and unassigned juliemr Feb 16, 2016

juliemr force-pushed the guinness2-2016-b branch 4 times, most recently from 7845154 to 0b492ac Compare February 17, 2016 17:17

vicb reviewed Feb 17, 2016
View reviewed changes

juliemr force-pushed the guinness2-2016-b branch from 0b492ac to 0151d09 Compare March 1, 2016 21:53

juliemr force-pushed the guinness2-2016-b branch 3 times, most recently from 3469c21 to 7b5c05a Compare March 3, 2016 06:31

juliemr force-pushed the guinness2-2016-b branch 2 times, most recently from 8d27e07 to ed552a2 Compare March 3, 2016 07:55

juliemr force-pushed the guinness2-2016-b branch from 1a4743c to 321dcdc Compare March 3, 2016 18:21

IgorMinar reviewed Mar 3, 2016
View reviewed changes

juliemr force-pushed the guinness2-2016-b branch 3 times, most recently from ddcbf4b to ec46ead Compare March 3, 2016 22:11

IgorMinar added pr_state: LGTM action: merge The PR is ready for merge by the caretaker labels Mar 3, 2016

vikerman added the zomg_admin: do merge label Mar 3, 2016

mary-poppins removed the zomg_admin: do merge label Mar 3, 2016

juliemr force-pushed the guinness2-2016-b branch from ec46ead to effab53 Compare March 4, 2016 01:05

vikerman added the zomg_admin: do merge label Mar 4, 2016

vikerman closed this Mar 4, 2016

angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 8, 2019

Conversation

juliemr commented Feb 16, 2016

Uh oh!

juliemr commented Feb 16, 2016

Uh oh!

juliemr commented Feb 16, 2016

Uh oh!

juliemr commented Feb 16, 2016

Uh oh!

vicb Feb 17, 2016

Choose a reason for hiding this comment

Uh oh!

juliemr Feb 17, 2016

Choose a reason for hiding this comment

Uh oh!

vicb commented Feb 17, 2016

Uh oh!

juliemr commented Feb 17, 2016

Uh oh!

juliemr commented Mar 1, 2016

Uh oh!

juliemr commented Mar 3, 2016

Uh oh!

juliemr commented Mar 3, 2016

Uh oh!

juliemr commented Mar 3, 2016

Uh oh!

zoechi commented Mar 3, 2016

Uh oh!

zoechi commented Mar 3, 2016

Uh oh!

juliemr commented Mar 3, 2016

Uh oh!

zoechi commented Mar 3, 2016

Uh oh!

juliemr commented Mar 3, 2016

Uh oh!

IgorMinar Mar 3, 2016

Choose a reason for hiding this comment

Uh oh!

juliemr Mar 3, 2016

Choose a reason for hiding this comment

Uh oh!

mary-poppins commented Mar 3, 2016

Uh oh!

kevmoo commented Mar 3, 2016

Uh oh!

juliemr commented Mar 3, 2016

Uh oh!

kevmoo commented Mar 3, 2016

Uh oh!

juliemr commented Mar 3, 2016

Uh oh!

vikerman commented Mar 4, 2016

Uh oh!

angular-automatic-lock-bot bot commented Sep 8, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants