X Tutup
Skip to content

chore: noImplicitAny fixes#7030

Closed
mhevery wants to merge 1 commit intoangular:masterfrom
mhevery:noImplicitAny
Closed

chore: noImplicitAny fixes#7030
mhevery wants to merge 1 commit intoangular:masterfrom
mhevery:noImplicitAny

Conversation

@mhevery
Copy link
Copy Markdown
Contributor

@mhevery mhevery commented Feb 12, 2016

to caretaker: If there are any collisions just revert that any file.

This PR just add types, there are no side effects.

alexeagle
alexeagle reviewed Feb 12, 2016
View reviewed changes
modules/angular2/src/common/directives/ng_class.ts Outdated
Copy link
Copy Markdown
Contributor

@alexeagle alexeagle Feb 12, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: single quotes (looks like a WebStorm auto-import!)

Copy link
Copy Markdown
Contributor Author

@mhevery mhevery Feb 12, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

@alexeagle alexeagle added action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews pr_state: LGTM labels Feb 12, 2016
@mhevery mhevery removed the action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews label Feb 12, 2016
@mhevery mhevery assigned mhevery and unassigned alexeagle Feb 12, 2016
@mhevery mhevery added the action: merge The PR is ready for merge by the caretaker label Feb 12, 2016
@btford btford added action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews and removed action: merge The PR is ready for merge by the caretaker labels Feb 17, 2016
@btford
Copy link
Copy Markdown
Contributor

btford commented Feb 17, 2016

@mhevery tests still failing :(

@mhevery mhevery force-pushed the noImplicitAny branch 7 times, most recently from 1d5bca8 to e7e6651 Compare February 19, 2016 04:37
@mhevery
Copy link
Copy Markdown
Contributor Author

mhevery commented Feb 19, 2016

Tast now passing, The last failure seems to be an issue with sauce labs

19 02 2016 05:22:06.651:ERROR [launcher.sauce]: Can not start chrome beta
  [get("http://localhost:9876/?id=12029306")] Error response status: 6 Selenium error: no such session
  (Driver info: chromedriver=2.20.353141 (da3cb4b52d3a04ce079546eac4dc96182f58602b),platform=Linux 3.13.0-32-generic x86)

@mhevery mhevery added the action: merge The PR is ready for merge by the caretaker label Feb 19, 2016
@mhevery mhevery removed the action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews label Feb 19, 2016
@mhevery mhevery force-pushed the noImplicitAny branch 6 times, most recently from 2a2730f to 93df907 Compare February 20, 2016 06:07
This was referenced Feb 20, 2016
Closed
Closed
@mary-poppins
Copy link
Copy Markdown

mary-poppins commented Feb 24, 2016

Merging PR #7030 on behalf of @vsavkin to branch presubmit-vsavkin-pr-7030.

@mhevery
Copy link
Copy Markdown
Contributor Author

mhevery commented Feb 25, 2016

Merged: 8bb66a5

@mhevery mhevery closed this Feb 25, 2016
@mhevery mhevery deleted the noImplicitAny branch June 2, 2017 17:05
@angular-automatic-lock-bot
Copy link
Copy Markdown

angular-automatic-lock-bot bot commented Sep 11, 2019

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 11, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

@mhevery mhevery

Labels

action: merge The PR is ready for merge by the caretaker cla: yes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@mhevery @btford @mary-poppins @alexeagle @vsavkin @googlebot
X Tutup