feat(ViewEncapsulation): introduce the EmulatedLegacy value.#7014
Closed
vicb wants to merge 1 commit intoangular:masterfrom
Closed
feat(ViewEncapsulation): introduce the EmulatedLegacy value.#7014vicb wants to merge 1 commit intoangular:masterfrom
vicb wants to merge 1 commit intoangular:masterfrom
Conversation
vicb
added
action: review
Contributor
There was a problem hiding this comment.
Just refer to Emulated and drop the lengthy explanation
tbosch
added
pr_state: LGTM
and removed
action: review
ref angular#5390 The Emulated mode will be updated to properly shim selectors after :host so that they don't cross child component shadow boundaries. This will be a breaking change. The EmulatedLegacy mode has the same semantics has the current Emulated mode.
Contributor
Author
|
/cc @TedSander |
Contributor
|
@vicb could you rebase this one? It looks like that's all this still needs? |
Contributor
Author
|
no more needed after #7563 |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ref #5390
The Emulated mode will be updated to properly shim selectors after :host so that they don't cross child component shadow boundaries. This will be a breaking change.
The EmulatedLegacy mode has the same semantics has the current Emulated mode.