fix(upgrade): support deferred bootstrap#7005
Conversation
|
It would be great to add an e2e test for https://github.com/angular/angular/tree/master/modules/playground/src/upgrade - that would probably belong at |
|
Other than that, LGTM! |
teropa
force-pushed
the
fix-upgrade-deferred-bootstrap
branch
2 times, most recently
from
46271c7 to
2993a21
Compare
Have UpgradeAdapter wait for Angular 1 to bootstrap before running delayed $applys. This fixes the use of UpgradeAdapter with Protractor. Closes angular#6547
teropa
force-pushed
the
fix-upgrade-deferred-bootstrap
branch
from
2993a21 to
4400d88
Compare
|
Added an E2E test for upgrade, using the existing upgrade playground code. The failure on Travis looks unrelated to me. |
|
LGTM, I've seen that Travis error before, it's a flake. I restarted the build. cc @sjelin who is starting to look into ng-upgrade stuff. |
|
Thanks @teropa! |
|
I think this PR is no longer relevant: #7603 |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
5 participants
Have UpgradeAdapter wait for Angular 1 to bootstrap before running
delayed $applys.
This fixes the use of UpgradeAdapter with Protractor.
Closes #6547