X Tutup
Skip to content

refactor(dart/transform): Simplify deferred rewriting#6994

Closed
kegluneq wants to merge 1 commit intoangular:masterfrom
kegluneq:quiver_dev
Closed

refactor(dart/transform): Simplify deferred rewriting#6994
kegluneq wants to merge 1 commit intoangular:masterfrom
kegluneq:quiver_dev

Conversation

@kegluneq
Copy link
Copy Markdown

@kegluneq kegluneq commented Feb 10, 2016

Sorry for the large refactor - originally I meant to just remove the use of package:quiver, but once I started pulling on that thread...

Thanks!

Simplify the DeferredRewriting and move package:quiver to a dev
dependency.

@kegluneq kegluneq added comp: dart-transformer action: review The PR is still awaiting reviews from at least one requested reviewer refactoring Issue that involves refactoring or code-cleanup labels Feb 10, 2016
jakemac53
jakemac53 reviewed Feb 10, 2016
View reviewed changes
modules_dart/transform/lib/src/transform/deferred_rewriter/rewriter.dart Outdated
Copy link
Copy Markdown
Contributor

@jakemac53 jakemac53 Feb 10, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shouldn't this really count as part of the time?

Copy link
Copy Markdown
Contributor

@jakemac53 jakemac53 Feb 10, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Or you could log it as a separate named operation if you want to keep it separate. I think its important to track this time somewhere though.

Copy link
Copy Markdown
Author

@kegluneq kegluneq Feb 10, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Discussed offline - I like this idea but will tackle it in a separate PR.

@jakemac53
Copy link
Copy Markdown
Contributor

jakemac53 commented Feb 10, 2016

minor nit about process method, otherwise lgtm

@jakemac53 jakemac53 assigned kegluneq and unassigned jakemac53 Feb 10, 2016
@jakemac53 jakemac53 added pr_state: LGTM and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Feb 10, 2016
refactor(dart/transform): Simplify deferred rewriting
7e64820 
Simplify the DeferredRewriting and move package:quiver to a dev
dependency.
@kegluneq kegluneq added the action: merge The PR is ready for merge by the caretaker label Feb 10, 2016
@kegluneq kegluneq assigned btford and unassigned kegluneq Feb 10, 2016
@mary-poppins
Copy link
Copy Markdown

mary-poppins commented Feb 10, 2016

Merging PR #6994 on behalf of @btford to branch presubmit-btford-pr-6994.

@mhevery mhevery closed this in 1fd924f Feb 10, 2016
@kegluneq kegluneq deleted the quiver_dev branch February 11, 2016 01:18
@angular-automatic-lock-bot
Copy link
Copy Markdown

angular-automatic-lock-bot bot commented Sep 8, 2019

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

action: merge The PR is ready for merge by the caretaker cla: yes refactoring Issue that involves refactoring or code-cleanup

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@kegluneq @jakemac53 @mary-poppins @btford @googlebot
X Tutup