X Tutup
Skip to content

refactor(dart/transform): Migrates tests to use package:test#6896

Closed
kegluneq wants to merge 1 commit intoangular:masterfrom
kegluneq:package_test
Closed

refactor(dart/transform): Migrates tests to use package:test#6896
kegluneq wants to merge 1 commit intoangular:masterfrom
kegluneq:package_test

Conversation

@kegluneq
Copy link
Copy Markdown

@kegluneq kegluneq commented Feb 4, 2016

Our transformer unit tests currently use package:guinness, which uses
package:unittest under the covers. package:unittest has been updated and
renamed package:test, so for simplicity migrate test to use package:test
syntax.

@kegluneq kegluneq added comp: dart-transformer refactoring Issue that involves refactoring or code-cleanup labels Feb 4, 2016
@zoechi
Copy link
Copy Markdown
Contributor

zoechi commented Feb 4, 2016

Love it! Much more darty :)
No offence meant for victors Guinnes package though.

@kegluneq kegluneq assigned vsavkin and unassigned jakemac53 Feb 4, 2016
@vsavkin vsavkin assigned kegluneq and unassigned vsavkin Feb 8, 2016
@kegluneq kegluneq added the action: merge The PR is ready for merge by the caretaker label Feb 8, 2016
@kegluneq kegluneq assigned IgorMinar and unassigned kegluneq Feb 8, 2016
@kegluneq kegluneq mentioned this pull request Feb 10, 2016
Closed
@kegluneq kegluneq assigned btford and unassigned IgorMinar Feb 11, 2016
@juliemr juliemr mentioned this pull request Feb 16, 2016
Closed
@btford
Copy link
Copy Markdown
Contributor

btford commented Feb 17, 2016

@kegluneq build went red: https://travis-ci.org/angular/angular/jobs/109734984

Can you investigate?

@btford btford added action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews and removed action: merge The PR is ready for merge by the caretaker labels Feb 17, 2016
@kegluneq
Copy link
Copy Markdown
Author

kegluneq commented Feb 17, 2016

@vsmenon @jmesserly

This is almost certainly a change to ddc. I'll talk to the folks working on that project about it.

@vsmenon
Copy link
Copy Markdown
Contributor

vsmenon commented Feb 17, 2016

The DDC bot is complaining that there are more severe errors in the Dart code (was 6, now 11). Should only be code reachable from samples - I'm surprised this is trigger - it's only changing tests?

@kegluneq
Copy link
Copy Markdown
Author

kegluneq commented Feb 17, 2016

Looks like it was ae275fa causing the breakage.

The number of allowed ddc severe errors was upped in a7e9bc9, so this should no longer be blocked.

@kegluneq kegluneq assigned matsko and unassigned btford Feb 17, 2016
@kegluneq
Copy link
Copy Markdown
Author

kegluneq commented Feb 17, 2016

@matsko, looks like the js.dev build is broken/flaky - what would you like me to do?

@juliemr juliemr removed the action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews label Feb 17, 2016
@kegluneq kegluneq added the action: merge The PR is ready for merge by the caretaker label Feb 20, 2016
@kegluneq kegluneq assigned vsavkin and unassigned matsko Feb 25, 2016
refactor(dart/transform): Migrates tests to use package:test
6e7ef4d 
Our transformer unit tests currently use package:guinness, which uses
package:unittest under the covers. package:unittest has been updated and
renamed package:test, so for simplicity migrate test to use package:test
syntax.
@vsavkin
Copy link
Copy Markdown
Contributor

vsavkin commented Mar 1, 2016

Merged via 28a7811

@vsavkin vsavkin closed this Mar 1, 2016
@kegluneq kegluneq deleted the package_test branch March 7, 2016 17:13
@angular-automatic-lock-bot
Copy link
Copy Markdown

angular-automatic-lock-bot bot commented Sep 8, 2019

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

@vsavkin vsavkin

Labels

action: merge The PR is ready for merge by the caretaker cla: yes refactoring Issue that involves refactoring or code-cleanup

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

10 participants

@kegluneq @zoechi @btford @vsmenon @vsavkin @matsko @IgorMinar @jakemac53 @juliemr @googlebot
X Tutup