fix(router): Added route data to normalized async route#6802
fix(router): Added route data to normalized async route#6802brandonroberts wants to merge 1 commit intoangular:masterfrom
Conversation
7863406 to
fc79e4c
Compare
0a9d047 to
ea322e4
Compare
|
I'm getting a Dart build error. Any ideas on how to fix? |
|
In Dart AFAIK a class is passed instead of an object (Map/_LinkedHashMap). I assume it's this line it should be something like this instead |
|
@zoechi right, but the test is for making sure if you don't provide a type that it still works. Maybe I need to move this test to the ng1 router tests. Thanks! |
e7e0daf to
1172272
Compare
|
@petebacondarwin @btford this PR is ready. Both of my test failures were from the builds flaking out. |
|
LGTM |
1172272 to
ceb94bb
Compare
|
Rebased this one again |
ceb94bb to
1991bbb
Compare
|
Thanks @brandonroberts! Looks like this last failure is a flake. I'm re-running it to double check and will merge if it passes. |
|
👍 |
|
Merging PR #6802 on behalf of @btford to branch presubmit-btford-pr-6802. |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Closes #6272 #6636
cc: @petebacondarwin