X Tutup
Skip to content

fix(router): Added route data to normalized async route#6802

Closed
brandonroberts wants to merge 1 commit intoangular:masterfrom
brandonroberts:router-fix-async-route-config
Closed

fix(router): Added route data to normalized async route#6802
brandonroberts wants to merge 1 commit intoangular:masterfrom
brandonroberts:router-fix-async-route-config

Conversation

@brandonroberts
Copy link
Copy Markdown
Contributor

@brandonroberts brandonroberts force-pushed the router-fix-async-route-config branch from 7863406 to fc79e4c Compare January 31, 2016 21:29
@petebacondarwin petebacondarwin added type: bug/fix comp: router action: review The PR is still awaiting reviews from at least one requested reviewer effort1: hours labels Jan 31, 2016
@petebacondarwin petebacondarwin self-assigned this Jan 31, 2016
@brandonroberts brandonroberts force-pushed the router-fix-async-route-config branch 2 times, most recently from 0a9d047 to ea322e4 Compare February 2, 2016 02:35
@brandonroberts
Copy link
Copy Markdown
Contributor Author

I'm getting a Dart build error. Any ideas on how to fix?

@zoechi
Copy link
Copy Markdown
Contributor

zoechi commented Feb 2, 2016

In Dart AFAIK a class is passed instead of an object (Map/_LinkedHashMap).

I assume it's this line

{path: '/route-data', loader: asyncRouteDataCmp, data: {isAdmin: true}}

it should be something like this instead

new AsyncRoute(path: '/route-data', loader: asyncRouteDataCmp, data: {isAdmin: true});

@brandonroberts
Copy link
Copy Markdown
Contributor Author

@zoechi right, but the test is for making sure if you don't provide a type that it still works. Maybe I need to move this test to the ng1 router tests.

Thanks!

@brandonroberts brandonroberts force-pushed the router-fix-async-route-config branch 4 times, most recently from e7e0daf to 1172272 Compare February 2, 2016 13:37
@brandonroberts
Copy link
Copy Markdown
Contributor Author

@petebacondarwin @btford this PR is ready. Both of my test failures were from the builds flaking out.

@petebacondarwin
Copy link
Copy Markdown
Contributor

LGTM

@petebacondarwin petebacondarwin added action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Feb 2, 2016
@brandonroberts brandonroberts force-pushed the router-fix-async-route-config branch from 1172272 to ceb94bb Compare February 9, 2016 02:03
@brandonroberts
Copy link
Copy Markdown
Contributor Author

Rebased this one again

@brandonroberts brandonroberts force-pushed the router-fix-async-route-config branch from ceb94bb to 1991bbb Compare February 9, 2016 18:45
@btford
Copy link
Copy Markdown
Contributor

btford commented Feb 9, 2016

Thanks @brandonroberts!

Looks like this last failure is a flake. I'm re-running it to double check and will merge if it passes.

@brandonroberts
Copy link
Copy Markdown
Contributor Author

👍

@mary-poppins
Copy link
Copy Markdown

Merging PR #6802 on behalf of @btford to branch presubmit-btford-pr-6802.

@mhevery mhevery closed this in df7885c Feb 9, 2016
@brandonroberts brandonroberts deleted the router-fix-async-route-config branch March 4, 2016 14:57
@angular-automatic-lock-bot
Copy link
Copy Markdown

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

action: merge The PR is ready for merge by the caretaker cla: yes effort1: hours type: bug/fix

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Async routes cause route data to be lost

6 participants

X Tutup