X Tutup
Skip to content

chore(ddc): add e2e test infra + first test#6783

Closed
yjbanov wants to merge 2 commits intoangular:masterfrom
yjbanov:ddc-5-e2e
Closed

chore(ddc): add e2e test infra + first test#6783
yjbanov wants to merge 2 commits intoangular:masterfrom
yjbanov:ddc-5-e2e

Conversation

@yjbanov
Copy link
Copy Markdown
Contributor

@yjbanov yjbanov commented Jan 30, 2016

Also bumped error cap to 10 because the new version of DDC is reporting more errors.

@yjbanov
Copy link
Copy Markdown
Contributor Author

yjbanov commented Feb 3, 2016

This is currently blocked by #6846. Once the issue is resolved I can easily clean up this PR for review.

@vsmenon
Copy link
Copy Markdown
Contributor

vsmenon commented Feb 12, 2016

@IgorMinar This is the PR blocked on #6846. Is there a way to rerun it on travis before submitting?

@yjbanov
Copy link
Copy Markdown
Contributor Author

yjbanov commented Feb 12, 2016

I'll rebase on top of @Mlaval's PR #5393 and see.

@googlebot
Copy link
Copy Markdown

We found a Contributor License Agreement for you (the sender of this pull request) and all commit authors, but as best as we can tell these commits were authored by someone else. If that's the case, please add them to this pull request and have them confirm that they're okay with these commits being contributed to Google. If we're mistaken and you did author these commits, just reply here to confirm.

@yjbanov yjbanov force-pushed the ddc-5-e2e branch 2 times, most recently from 3c449a5 to 09c862f Compare February 19, 2016 23:43
@vsavkin vsavkin removed their assignment Feb 25, 2016
@googlebot
Copy link
Copy Markdown

CLAs look good, thanks!

@IgorMinar
Copy link
Copy Markdown
Contributor

#6846 is fixed now so this PR should be unblocked

@vsmenon
Copy link
Copy Markdown
Contributor

vsmenon commented Mar 3, 2016

@yjbanov is this rebased or still failing on the latest?

@yjbanov
Copy link
Copy Markdown
Contributor Author

yjbanov commented Mar 3, 2016

This is failing with rebase on top of master after #6846 was submitted. I only gave it one attempt. Haven't looked at what's going on yet.

mhevery pushed a commit to mhevery/angular that referenced this pull request Mar 22, 2016
@mhevery
Copy link
Copy Markdown
Contributor

mhevery commented Mar 22, 2016

Replaced by: #7725

@mhevery mhevery closed this Mar 22, 2016
mhevery pushed a commit that referenced this pull request Mar 22, 2016
@angular-automatic-lock-bot
Copy link
Copy Markdown

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants

X Tutup