X Tutup
Skip to content

perf(dart/transform): Only process deferred libs when necessary#6745

Closed
kegluneq wants to merge 1 commit intoangular:masterfrom
kegluneq:smart_deferred_rewriter
Closed

perf(dart/transform): Only process deferred libs when necessary#6745
kegluneq wants to merge 1 commit intoangular:masterfrom
kegluneq:smart_deferred_rewriter

Conversation

@kegluneq
Copy link
Copy Markdown

@kegluneq kegluneq commented Jan 28, 2016

/cc @vsavkin, @yjbanov

Previously, every .dart file in a package was processed to ensure proper
initialization of deferred loaded libraries.

Update the transformer to avoid processing libraries which we know do
not import any deferred libraries.

@kegluneq kegluneq added area: performance Issues related to performance comp: dart-transformer action: review The PR is still awaiting reviews from at least one requested reviewer labels Jan 28, 2016
jakemac53
jakemac53 reviewed Jan 28, 2016
View reviewed changes
modules_dart/transform/lib/src/transform/common/names.dart Outdated
Copy link
Copy Markdown
Contributor

@jakemac53 jakemac53 Jan 28, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sidenote, but can this be deleted now?

Copy link
Copy Markdown
Author

@kegluneq kegluneq Jan 28, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is removed in #6711

Copy link
Copy Markdown
Contributor

@jakemac53 jakemac53 Jan 28, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah ok thats just not merged yet, makes sense

@jakemac53
Copy link
Copy Markdown
Contributor

jakemac53 commented Jan 28, 2016

LGTM, after offline discussions

@kegluneq kegluneq added pr_state: LGTM action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Jan 28, 2016
kegluneq pushed a commit to kegluneq/angular that referenced this pull request Jan 28, 2016
refactor(dart/transform): Error in name convert funcs on unexpected i…
b35a971 
…nput

Issue raised in PR angular#6745.
Previously, the transformer name conversion functions could return the
input string on unexpected input, which is almost certainly an error.

`throw` in this case instead, so we know early that something has likely
gone wrong.
@kegluneq kegluneq mentioned this pull request Jan 28, 2016
Closed
@mary-poppins
Copy link
Copy Markdown

mary-poppins commented Feb 1, 2016

Merging PR #6745 on behalf of @alexeagle to branch presubmit-alexeagle-pr-6745.

@mary-poppins
Copy link
Copy Markdown

mary-poppins commented Feb 1, 2016

Merging PR #6745 on behalf of @alexeagle to branch presubmit-alexeagle-pr-6745.

@mary-poppins
Copy link
Copy Markdown

mary-poppins commented Feb 1, 2016

Merging PR #6745 on behalf of @alexeagle to branch presubmit-alexeagle-pr-6745.

perf(dart/transform): Only process deferred libs when necessary
798576e 
Previously, every .dart file in a package was processed to ensure proper
initialization of deferred loaded libraries.

Update the transformer to avoid processing libraries which we know do
not import any deferred libraries.
@kegluneq kegluneq force-pushed the smart_deferred_rewriter branch from b3608b7 to 798576e Compare February 2, 2016 22:57
@kegluneq kegluneq assigned alexeagle and unassigned jakemac53 Feb 2, 2016
@kegluneq
Copy link
Copy Markdown
Author

kegluneq commented Feb 2, 2016

This had a merge conflict with #6711. It is now fixed & ready to merge (assuming Travis is happy)

@mary-poppins
Copy link
Copy Markdown

mary-poppins commented Feb 2, 2016

Merging PR #6745 on behalf of @alexeagle to branch presubmit-alexeagle-pr-6745.

@mhevery mhevery closed this in f56df65 Feb 2, 2016
mhevery pushed a commit that referenced this pull request Feb 3, 2016
@kegluneq
refactor(dart/transform): Error in name convert funcs on unexpected i…
cfef76f 
…nput

Issue raised in PR #6745.
Previously, the transformer name conversion functions could return the
input string on unexpected input, which is almost certainly an error.

`throw` in this case instead, so we know early that something has likely
gone wrong.

Closes #6753
@kegluneq kegluneq deleted the smart_deferred_rewriter branch February 3, 2016 00:43
@angular-automatic-lock-bot
Copy link
Copy Markdown

angular-automatic-lock-bot bot commented Sep 7, 2019

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 7, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

@alexeagle alexeagle

Labels

action: merge The PR is ready for merge by the caretaker area: performance Issues related to performance cla: yes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@kegluneq @jakemac53 @mary-poppins @alexeagle @googlebot
X Tutup