X Tutup
Skip to content

feat(dart/transform): Generate all code into <file>.template.dart#6711

Closed
kegluneq wants to merge 2 commits intoangular:masterfrom
kegluneq:xform_unify_outputs
Closed

feat(dart/transform): Generate all code into <file>.template.dart#6711
kegluneq wants to merge 2 commits intoangular:masterfrom
kegluneq:xform_unify_outputs

Conversation

@kegluneq
Copy link
Copy Markdown

@kegluneq kegluneq commented Jan 27, 2016

/cc @yjbanov

Previously, we generated the code to initialize the reflector into the
.ng_deps.dart and the compiled template and change detector code
into .template.dart.

Update the transformer to generate all code into .template.dart to
avoid the additional HTTP requests necessary when debugging
applications in Dartium.

@kegluneq kegluneq added area: performance Issues related to performance comp: dart-transformer action: review The PR is still awaiting reviews from at least one requested reviewer labels Jan 27, 2016
@yjbanov
Copy link
Copy Markdown
Contributor

yjbanov commented Jan 27, 2016

This is a great change. I'm wondering if template is a good infix for the file name given that:

  • it may actually not contain any template code (e.g. injectables and directives)
  • it is angular-specific and yet the name does not reflect that

How about .ng.dart or .ng2.dart?

@kegluneq
Copy link
Copy Markdown
Author

kegluneq commented Jan 27, 2016

/cc @tbosch
Totally agreed on the naming, however because the .template.dart files reference each other, this will require updating the Template Compiler, which Tobias was hesitant to do right now.

Can we take renaming the output as a separate TODO? At the same time we do it, perhaps we can unify the naming code that is currently duplicated in the transformer & the template compiler.

@kegluneq kegluneq force-pushed the xform_unify_outputs branch from aa663c9 to d132c33 Compare January 27, 2016 01:46
@yjbanov
Copy link
Copy Markdown
Contributor

yjbanov commented Jan 27, 2016

SGTM. Let's file an issue to follow-up.

@kegluneq
Copy link
Copy Markdown
Author

kegluneq commented Jan 27, 2016

Spun off #6712

@kegluneq kegluneq force-pushed the xform_unify_outputs branch from d132c33 to fd58433 Compare January 27, 2016 17:42
@vsavkin vsavkin added pr_state: LGTM and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Jan 28, 2016
@vsavkin vsavkin assigned kegluneq and unassigned vsavkin Jan 28, 2016
Tim Blasi added 2 commits January 28, 2016 09:22
feat(dart/transform): Generate all code into <file>.template.dart
d8a0f95 
Previously, we generated the code to initialize the reflector into the
<file>.ng_deps.dart and the compiled template and change detector code
into <file>.template.dart.

Update the transformer to generate all code into <file>.template.dart to
avoid the additional HTTP requests necessary when debugging
applications in Dartium.
test(dart/transform): Update unit tests to expect code in <file>.temp…
a8495fb 
…late.dart
@kegluneq kegluneq force-pushed the xform_unify_outputs branch from fd58433 to a8495fb Compare January 28, 2016 17:22
@kegluneq kegluneq mentioned this pull request Jan 28, 2016
Closed
@kegluneq kegluneq added the action: merge The PR is ready for merge by the caretaker label Jan 28, 2016
@mary-poppins
Copy link
Copy Markdown

mary-poppins commented Feb 1, 2016

Merging PR #6711 on behalf of @alexeagle to branch presubmit-alexeagle-pr-6711.

@mary-poppins
Copy link
Copy Markdown

mary-poppins commented Feb 1, 2016

Merging PR #6711 on behalf of @alexeagle to branch presubmit-alexeagle-pr-6711.

@mhevery mhevery closed this in 566d3ed Feb 1, 2016
@kegluneq kegluneq deleted the xform_unify_outputs branch February 3, 2016 00:44
@angular-automatic-lock-bot
Copy link
Copy Markdown

angular-automatic-lock-bot bot commented Sep 7, 2019

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 7, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

@kegluneq kegluneq

Labels

action: merge The PR is ready for merge by the caretaker area: performance Issues related to performance cla: yes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@kegluneq @yjbanov @mary-poppins @vsavkin @alexeagle @googlebot
X Tutup