X Tutup
Skip to content

chore: track size of a "Hello world" app built with SystemJS #6621

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
pkozlowski-opensource wants to merge 1 commit into from
Closed

chore: track size of a "Hello world" app built with SystemJS #6621

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
82 changes: 60 additions & 22 deletions gulpfile.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -170,15 +170,14 @@ var BENCHPRESS_BUNDLE_CONFIG = {

var PAYLOAD_TESTS_CONFIG = {
ts: {
sizeLimits: {'uncompressed': 550 * 1024, 'gzip level=9': 120 * 1024},
webpack: {
cases: ['hello_world'],
bundleName: 'app-bundle-deps.min.js',
dist: function(caseName) {
return path.join(__dirname, CONFIG.dest.js.prod.es5, 'payload_tests', caseName,
'ts/webpack');
}
}
bundleName: 'app-bundle-deps.min.js',
cases: ['hello_world'],
dist: function(caseName, packaging) {
return path.join(__dirname, CONFIG.dest.js.prod.es5, 'payload_tests', caseName,
'ts/' + packaging);
},
systemjs: {sizeLimits: {'uncompressed': 850 * 1024, 'gzip level=9': 165 * 1024}},
webpack: {sizeLimits: {'uncompressed': 550 * 1024, 'gzip level=9': 120 * 1024}}
}
};

Expand Down Expand Up @@ -678,19 +677,18 @@ gulp.task('test.payload.js/ci', function(done) {
runSequence('build.payload.js', '!checkAndReport.payload.js', sequenceComplete(done));
});

gulp.task('build.payload.js', ['build.js.prod'],
function(done) { runSequence('!build.payload.js.webpack', sequenceComplete(done)); });
gulp.task('build.payload.js', ['build.js'], function(done) {
runSequence('!build.payload.js.webpack', '!build.payload.js.systemjs', sequenceComplete(done));
});

gulp.task('!build.payload.js.webpack', function() {
var q = require('q');
var webpack = q.denodeify(require('webpack'));
var concat = require('gulp-concat');
var uglify = require('gulp-uglify');

var ES5_PROD_ROOT = __dirname + '/' + CONFIG.dest.js.prod.es5;

return q.all(PAYLOAD_TESTS_CONFIG.ts.webpack.cases.map(function(caseName) {
var CASE_PATH = PAYLOAD_TESTS_CONFIG.ts.webpack.dist(caseName);
return q.all(PAYLOAD_TESTS_CONFIG.ts.cases.map(function(caseName) {
var CASE_PATH = PAYLOAD_TESTS_CONFIG.ts.dist(caseName, 'webpack');

return webpack({
// bundle app + framework
Expand All @@ -710,8 +708,41 @@ gulp.task('!build.payload.js.webpack', function() {
'node_modules/reflect-metadata/Reflect.js',
CASE_PATH + '/app-bundle.js'
])
.pipe(concat(PAYLOAD_TESTS_CONFIG.ts.webpack.bundleName))
.pipe(uglify())
.pipe(gulpPlugins.concat(PAYLOAD_TESTS_CONFIG.ts.bundleName))
.pipe(gulpPlugins.uglify())
.pipe(gulp.dest(CASE_PATH))
.on('end', resolve)
.on('error', reject);
});
});
}));
});

gulp.task('!build.payload.js.systemjs', function() {
var bundler = require('./tools/build/bundle');

return Promise.all(PAYLOAD_TESTS_CONFIG.ts.cases.map(function(caseName) {
var CASE_PATH = PAYLOAD_TESTS_CONFIG.ts.dist(caseName, 'systemjs');

return bundler
.bundle(
{
paths: {'index': CASE_PATH + '/index.js'},
meta: {'angular2/core': {build: false}, 'angular2/platform/browser': {build: false}}
},
'index', CASE_PATH + '/index.register.js', {})
.then(function() {
return new Promise(function(resolve, reject) {
gulp.src([
'node_modules/systemjs/dist/system.src.js',
'dist/js/prod/es5/bundle/angular2-polyfills.js',
'dist/js/prod/es5/bundle/angular2.js',
'dist/js/prod/es5//rxjs/bundles/Rx.js',
CASE_PATH + '/index.register.js',
'tools/build/systemjs/payload_tests_import.js'
])
.pipe(gulpPlugins.concat(PAYLOAD_TESTS_CONFIG.ts.bundleName))
.pipe(gulpPlugins.uglify())
.pipe(gulp.dest(CASE_PATH))
.on('end', resolve)
.on('error', reject);
Expand All @@ -722,12 +753,19 @@ gulp.task('!build.payload.js.webpack', function() {

gulp.task('!checkAndReport.payload.js', function() {
var reportSize = require('./tools/analytics/reportsize');
var webPackConf = PAYLOAD_TESTS_CONFIG.ts.webpack;

return webPackConf.cases.reduce(function(sizeReportingStreams, caseName) {
sizeReportingStreams.add(
reportSize(webPackConf.dist(caseName) + '/' + webPackConf.bundleName,
{failConditions: PAYLOAD_TESTS_CONFIG.ts.sizeLimits, prefix: caseName}))
function caseSizeStream(caseName, packaging) {
return reportSize(PAYLOAD_TESTS_CONFIG.ts.dist(caseName, packaging) + '/' +
PAYLOAD_TESTS_CONFIG.ts.bundleName,
{
failConditions: PAYLOAD_TESTS_CONFIG.ts[packaging].sizeLimits,
prefix: caseName + '_' + packaging
})
}

return PAYLOAD_TESTS_CONFIG.ts.cases.reduce(function(sizeReportingStreams, caseName) {
sizeReportingStreams.add(caseSizeStream(caseName, 'systemjs'));
sizeReportingStreams.add(caseSizeStream(caseName, 'webpack'));
}, merge2());
});

Expand Down
11 changes: 11 additions & 0 deletions modules/payload_tests/hello_world/ts/systemjs/index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
<!doctype html>
<html>
<title>Angular 2.0 Hello World payload test</title>
<body>
<hello-app>
Loading...
</hello-app>
<script src="app-bundle-deps.min.js"></script>
</body>
</html>

15 changes: 15 additions & 0 deletions modules/payload_tests/hello_world/ts/systemjs/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,15 @@
import {Component} from 'angular2/core';
import {bootstrap} from 'angular2/platform/browser';

@Component({
selector: 'hello-app',
template: `
<h1>Hello, {{name}}!</h1>
<label> Say hello to: <input [value]="name" (input)="name = $event.target.value"></label>
`
})
class HelloCmp {
name = 'World';
}

bootstrap(HelloCmp);
2 changes: 1 addition & 1 deletion scripts/ci/build_and_test.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ elif [ "$MODE" = "build_only" ]; then
elif [ "$MODE" = "payload" ]; then
source ${SCRIPT_DIR}/env_dart.sh
./node_modules/.bin/gulp test.payload.dart/ci
./node_modules/.bin/gulp test.payload.js/ci
node --max-old-space-size=2000 ./node_modules/.bin/gulp test.payload.js/ci
Copy link
Copy Markdown
Contributor

@IgorMinar IgorMinar Jan 22, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is nice but doesn't address the memory issue in all workflows. many people suffer from this OOM issue when running gulp build or gulp build.js. Also circle.yaml calls it and that's why the circle build is currently flaky.

we should either figure out how to spawn the bundle task in a separate node process with higher heap settings or at least change npm's package.json for the build script to use the same invocation method of gulp so that circle ci is stable.

Copy link
Copy Markdown
Member Author

@pkozlowski-opensource pkozlowski-opensource Jan 22, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeh, I will dig into OOM issues in a separate PR

Copy link
Copy Markdown
Contributor

@IgorMinar IgorMinar Jan 22, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sgtm. go ahead and label for merge

On Fri, Jan 22, 2016 at 8:50 AM Pawel Kozlowski notifications@github.com
wrote:

In scripts/ci/build_and_test.sh
#6621 (comment):

@@ -22,7 +22,7 @@ elif [ "$MODE" = "build_only" ]; then
elif [ "$MODE" = "payload" ]; then
source ${SCRIPT_DIR}/env_dart.sh
./node_modules/.bin/gulp test.payload.dart/ci

  • ./node_modules/.bin/gulp test.payload.js/ci
  • node --max-old-space-size=2000 ./node_modules/.bin/gulp test.payload.js/ci

Yeh, I will dig into OOM issues in a separate PR

—
Reply to this email directly or view it on GitHub
https://github.com/angular/angular/pull/6621/files#r50559353.

else
${SCRIPT_DIR}/build_$MODE.sh
${SCRIPT_DIR}/test_$MODE.sh
Expand Down
2 changes: 1 addition & 1 deletion tools/broccoli/trees/browser_tree.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -227,7 +227,7 @@ module.exports = function makeBrowserTree(options, destinationPath) {
destDir: '/'
});

if (modules.benchmarks || modules.benchmarks_external || modules.playground) {
if (modules.playground) {
Copy link
Copy Markdown
Contributor

@IgorMinar IgorMinar Jan 22, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this right? don't we need to replace stuff in the html files of the benchmarks?

Copy link
Copy Markdown
Member Author

@pkozlowski-opensource pkozlowski-opensource Jan 22, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe so, I've just cleaned-up leftovers. Now benchmarks got their own if statements below.

htmlTree = replace(htmlTree, {
files: ['playground*/**/*.html'],
patterns: [
Expand Down
1 change: 1 addition & 0 deletions tools/build/systemjs/payload_tests_import.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
System.import('index').catch(console.error.bind(console));
X Tutup