chore: track size of a "Hello world" app built with SystemJS#6621
chore: track size of a "Hello world" app built with SystemJS#6621pkozlowski-opensource wants to merge 1 commit intoangular:masterfrom
Conversation
pkozlowski-opensource
added
the
action: review
pkozlowski-opensource
force-pushed
the
hello_world_systemjs_size_monitor
branch
2 times, most recently
from
8a74c1e to
e63f02e
Compare
There was a problem hiding this comment.
this is nice but doesn't address the memory issue in all workflows. many people suffer from this OOM issue when running gulp build or gulp build.js. Also circle.yaml calls it and that's why the circle build is currently flaky.
we should either figure out how to spawn the bundle task in a separate node process with higher heap settings or at least change npm's package.json for the build script to use the same invocation method of gulp so that circle ci is stable.
There was a problem hiding this comment.
Yeh, I will dig into OOM issues in a separate PR
There was a problem hiding this comment.
sgtm. go ahead and label for merge
On Fri, Jan 22, 2016 at 8:50 AM Pawel Kozlowski notifications@github.com
wrote:
In scripts/ci/build_and_test.sh
#6621 (comment):@@ -22,7 +22,7 @@ elif [ "$MODE" = "build_only" ]; then
elif [ "$MODE" = "payload" ]; then
source ${SCRIPT_DIR}/env_dart.sh
./node_modules/.bin/gulp test.payload.dart/ci
- ./node_modules/.bin/gulp test.payload.js/ci
- node --max-old-space-size=2000 ./node_modules/.bin/gulp test.payload.js/ci
Yeh, I will dig into OOM issues in a separate PR
—
Reply to this email directly or view it on GitHub
https://github.com/angular/angular/pull/6621/files#r50559353.
|
the rest looks good. if you want to I'm fine with merging this in as is and fixing the nitpicks in separate PRs. your call. |
IgorMinar
added
pr_state: LGTM
action: cleanup
pkozlowski-opensource
force-pushed
the
hello_world_systemjs_size_monitor
branch
from
e63f02e to
dbca7f0
Compare
|
Merging PR #6621 on behalf of @rkirov to branch presubmit-rkirov-pr-6621. |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
5 participants
No description provided.