X Tutup
Skip to content

fix(dart/transform): Ensure template codegen is completed sync #6603

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
kegluneq wants to merge 1 commit into from
Closed

fix(dart/transform): Ensure template codegen is completed sync #6603

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 19 additions & 1 deletion modules_dart/transform/lib/src/transform/common/logging.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,13 +22,31 @@ Future logElapsedAsync(Future asyncOperation(),
final timer = new Stopwatch()..start();
final result = await asyncOperation();
timer.stop();
_logElapsed(timer, operationName, assetId);
return result;
}

/// Writes a log entry at `LogLevel.FINE` granularity with the time taken by
/// `operation`.
///
/// Returns the result of executing `operation`.
dynamic logElapsedSync(dynamic operation(),
{String operationName: 'unknown', AssetId assetId}) {
final timer = new Stopwatch()..start();
final result = operation();
timer.stop();
_logElapsed(timer, operationName, assetId);
return result;
}

/// Logs the time since `timer` was started.
void _logElapsed(Stopwatch timer, String operationName, AssetId assetId) {
final buf =
new StringBuffer('[$operationName] took ${timer.elapsedMilliseconds} ms');
if (assetId != null) {
buf.write(' on $assetId');
}
log.fine(buf.toString(), asset: assetId);
return result;
}

/// Prints logged messages to the console.
Expand Down
4 changes: 3 additions & 1 deletion modules_dart/transform/lib/src/transform/template_compiler/generator.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,9 @@ Future<Outputs> processTemplates(AssetReader reader, AssetId assetId,

var savedReflectionCapabilities = reflector.reflectionCapabilities;
reflector.reflectionCapabilities = const NullReflectionCapabilities();
final compiledTemplates = await logElapsedAsync(() async {
// Since we need global state to remain consistent here, make sure not to do
// any asynchronous operations here.
final compiledTemplates = logElapsedSync(() {
return templateCompiler.compileTemplatesCodeGen(compileData);
}, operationName: 'compileTemplatesCodegen', assetId: assetId);
reflector.reflectionCapabilities = savedReflectionCapabilities;
Expand Down
X Tutup