X Tutup
Skip to content

refactor(view_compiler): codegen DI and Queries#6567

Closed
tbosch wants to merge 1 commit intoangular:masterfrom
tbosch:ultraperf_next
Closed

refactor(view_compiler): codegen DI and Queries#6567
tbosch wants to merge 1 commit intoangular:masterfrom
tbosch:ultraperf_next

Conversation

@tbosch
Copy link
Copy Markdown
Contributor

@tbosch tbosch commented Jan 19, 2016

Closes #6301

BREAKING CHANGE: TODO

@tbosch tbosch force-pushed the ultraperf_next branch 4 times, most recently from 9194bf3 to 24519b9 Compare January 22, 2016 17:45
@tbosch tbosch force-pushed the ultraperf_next branch 2 times, most recently from 3e48232 to d13bdc1 Compare February 1, 2016 15:37
@btford
Copy link
Copy Markdown
Contributor

btford commented Feb 1, 2016

@tbosch what is the status of this?

@tbosch tbosch force-pushed the ultraperf_next branch 2 times, most recently from ea92764 to 83b5cab Compare February 2, 2016 18:59
@tbosch
Copy link
Copy Markdown
Contributor Author

tbosch commented Feb 3, 2016

Still work in progress...

On Mon, Feb 1, 2016 at 3:22 PM Brian Ford notifications@github.com wrote:

@tbosch https://github.com/tbosch what is the status of this?


Reply to this email directly or view it on GitHub
#6567 (comment).

@tbosch tbosch force-pushed the ultraperf_next branch 2 times, most recently from 98b04e8 to a23c266 Compare February 5, 2016 18:43
@tbosch tbosch force-pushed the ultraperf_next branch 6 times, most recently from 4032d4e to c348fab Compare February 20, 2016 01:47
@tbosch tbosch force-pushed the ultraperf_next branch 7 times, most recently from 10c8aa2 to dae6e11 Compare March 8, 2016 22:59
@googlebot
Copy link
Copy Markdown

We found a Contributor License Agreement for you (the sender of this pull request) and all commit authors, but as best as we can tell these commits were authored by someone else. If that's the case, please add them to this pull request and have them confirm that they're okay with these commits being contributed to Google. If we're mistaken and you did author these commits, just reply here to confirm.

@tbosch tbosch force-pushed the ultraperf_next branch 2 times, most recently from 12df766 to eb8355a Compare March 22, 2016 00:34
@tbosch tbosch force-pushed the ultraperf_next branch 8 times, most recently from 73e0d96 to fe56b2b Compare March 28, 2016 23:09
@tbosch tbosch force-pushed the ultraperf_next branch 2 times, most recently from 60154a1 to b16a4b1 Compare March 30, 2016 03:01
@tbosch tbosch force-pushed the ultraperf_next branch 3 times, most recently from 18554b4 to 56eb69d Compare April 5, 2016 17:56
@googlebot
Copy link
Copy Markdown

CLAs look good, thanks!

@googlebot googlebot added cla: yes and removed cla: no labels Apr 5, 2016
@tbosch tbosch force-pushed the ultraperf_next branch 3 times, most recently from f6dc520 to 3c2423b Compare April 7, 2016 20:17
@googlebot
Copy link
Copy Markdown

We found a Contributor License Agreement for you (the sender of this pull request) and all commit authors, but as best as we can tell these commits were authored by someone else. If that's the case, please add them to this pull request and have them confirm that they're okay with these commits being contributed to Google. If we're mistaken and you did author these commits, just reply here to confirm.

@googlebot
Copy link
Copy Markdown

CLAs look good, thanks!

BREAKING CHANGE:
- Renderer:
  * renderComponent method is removed form `Renderer`, only present on `RootRenderer`
  * Renderer.setDebugInfo is removed. Renderer.createElement / createText / createTemplateAnchor
    now take the DebugInfo directly.
- Query semantics:
  * Queries don't work with dynamically loaded components.
  * e.g. for router-outlet: loaded components can't be queries via @ViewQuery,
    but router-outlet emits an event `activate` now that emits the activated component
- Exception classes and the context inside changed (renamed fields)
- DebugElement.attributes is an Object and not a Map in JS any more
- ChangeDetectorGenConfig was renamed into CompilerConfig
- AppViewManager.createEmbeddedViewInContainer / AppViewManager.createHostViewInContainer
  are removed, use the methods in ViewContainerRef instead
- Change detection order changed:
  * 1. dirty check component inputs
  * 2. dirty check content children
  * 3. update render nodes

Closes angular#6301
@angular-automatic-lock-bot
Copy link
Copy Markdown

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Change ViewCompiler to also generates DI, Locals and Queries

4 participants

X Tutup