refactor(compiler-cli): add warning for matching viewport @defer t…#65553
Open
SkyZeroZx wants to merge 1 commit intoangular:mainfrom
Open
refactor(compiler-cli): add warning for matching viewport @defer t…#65553SkyZeroZx wants to merge 1 commit intoangular:mainfrom
@defer t…#65553SkyZeroZx wants to merge 1 commit intoangular:mainfrom
Conversation
angular-robot
bot
added
the
area: compiler
JeanMeche
added
the
action: global presubmit
Member
|
/gemini review |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces a warning for @defer blocks when a viewport prefetch trigger has the same options as the main viewport trigger, making it redundant. The implementation correctly handles various cases, including empty and null options. The changes are well-tested. My feedback includes suggestions to improve code conciseness in the new helper function and to reduce boilerplate in the new tests for better maintainability.
...ges/compiler-cli/src/ngtsc/typecheck/extended/checks/defer_trigger_misconfiguration/index.ts
Show resolved
Hide resolved
...k/extended/test/checks/defer_trigger_misconfiguration/defer_trigger_misconfiguration_spec.ts
Show resolved
Hide resolved
AndrewKushnir
requested review from
JeanMeche
and removed request for
AndrewKushnir
SkyZeroZx
force-pushed
the
refactor/diagnostic-triggers-defer
branch
from
90f422b to
720ce86
Compare
SkyZeroZx
force-pushed
the
refactor/diagnostic-triggers-defer
branch
from
720ce86 to
4ae9459
Compare
…ger options Ensures that viewport `@defer` trigger prefetch warnings occur when the viewport options are identical, including cases with empty or no parameters.
SkyZeroZx
force-pushed
the
refactor/diagnostic-triggers-defer
branch
from
4ae9459 to
7f2c0e3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…rigger options
Ensures that viewport
@defertrigger prefetch warnings occur when the viewport options are identical, including cases with empty or no parameters.Currently, when using cases like don’t show warning, this PR adds proper support and fixes the missing viewport warning.
With viewport options
Using default viewport