X Tutup
Skip to content

feat(ngFor): Support convenience view local in ngFor#6528

Closed
gionkunz wants to merge 1 commit intoangular:masterfrom
gionkunz:ng-for-add-first-view-local
Closed

feat(ngFor): Support convenience view local in ngFor#6528
gionkunz wants to merge 1 commit intoangular:masterfrom
gionkunz:ng-for-add-first-view-local

Conversation

@gionkunz
Copy link
Copy Markdown
Contributor

No description provided.

@gionkunz
Copy link
Copy Markdown
Contributor Author

I know this is as easy as index === 0 but it just feels better to use a convenience view local first instead of expressions within my templates.

@0x-r4bbit
Copy link
Copy Markdown
Contributor

@gionkunz Would be cool if this gets a test too! :)

@gionkunz
Copy link
Copy Markdown
Contributor Author

@PascalPrecht Yeah, I wanted to check the reaction first before I spend more time on this ;-)

@tbosch tbosch added the action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews label Feb 1, 2016
@tbosch
Copy link
Copy Markdown
Contributor

tbosch commented Feb 1, 2016

Yes, this would be nice. But we need tests :-)

@gionkunz
Copy link
Copy Markdown
Contributor Author

gionkunz commented Feb 7, 2016

Sure, I'll come up with the tests shortly.

@gionkunz
Copy link
Copy Markdown
Contributor Author

@tbosch should be fine on the testing side

@gionkunz
Copy link
Copy Markdown
Contributor Author

gionkunz commented Mar 7, 2016

@tbosch any updates on this? Do I need to rebase to the latest and greatest?

@kara kara added action: review The PR is still awaiting reviews from at least one requested reviewer pr_state: LGTM action: merge The PR is ready for merge by the caretaker and removed action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews action: review The PR is still awaiting reviews from at least one requested reviewer labels Apr 8, 2016
@mary-poppins
Copy link
Copy Markdown

Merging PR #6528 on behalf of @alxhub to branch presubmit-alxhub-pr-6528.

@alxhub
Copy link
Copy Markdown
Member

alxhub commented Apr 11, 2016

Rebased for merge as #8013.

@alxhub alxhub closed this Apr 11, 2016
@angular-automatic-lock-bot
Copy link
Copy Markdown

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

action: merge The PR is ready for merge by the caretaker cla: yes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants

X Tutup