fix(router): fix url path for star segment in path recognizer#6514
Closed
davidreher wants to merge 4 commits intoangular:masterfrom
Closed
fix(router): fix url path for star segment in path recognizer#6514davidreher wants to merge 4 commits intoangular:masterfrom
davidreher wants to merge 4 commits intoangular:masterfrom
Conversation
If you register the route `/app/*location` and invoke a url like `/app/foo/bar` the PathRecognizer should return a url path equal to the invoked url. Before this patch, everything after `foo` was ignored, which resulted in a redirect to `/app/foo` which was probably not intended (at least in the angular 1.5 component router).
…star-segment-in-path-recognizer
davidreher
changed the title
Contributor
Author
|
@btford @petebacondarwin can you take a look? |
Contributor
|
LGTM |
petebacondarwin
added
pr_state: LGTM
action: merge
Contributor
|
I've squashed your commits and filed #6976– I'll merge the PR from there. Thanks! |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If you register the route
/app/*locationand invoke a url like/app/foo/barthe PathRecognizer should return a url path equal to the invoked url.Before this patch, everything after
foowas ignored, which resulted in a redirect to/app/foowhich was probably not intended (at least in the angular 1.5 component router).This is a bugfix for #6305.