fix(Dart): make some playground samples run with Dart Dev Compiler#6441
Closed
jacob314 wants to merge 1 commit intoangular:masterfrom
Closed
fix(Dart): make some playground samples run with Dart Dev Compiler#6441jacob314 wants to merge 1 commit intoangular:masterfrom
jacob314 wants to merge 1 commit intoangular:masterfrom
Conversation
jacob314
force-pushed
the
dart-dev-compiler-fixes
branch
2 times, most recently
from
6619186 to
bae7cc0
Compare
Resolve all invalid field override errors, workaround current reflection limitations in Dart Dev Compiler. todo, hello_world and key_events samples now work with Dart Dev Compiler. BREAKING CHANGE: remove TemplateRef.elementRef setter
jacob314
force-pushed
the
dart-dev-compiler-fixes
branch
from
a358ed7 to
ed31812
Compare
Contributor
|
LGTM |
yjbanov
added
pr_state: LGTM
action: merge
Contributor
|
A note on the breaking change for future reference. We've had the |
|
Merging PR #6441 on behalf of @jeffbcross to branch presubmit-jeffbcross-pr-6441. |
|
Merging PR #6441 on behalf of @rkirov to branch presubmit-rkirov-pr-6441. |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolve all invalid field override errors, workaround current
reflection limitations in Dart Dev Compiler. todo, hello_world and
key_events samples now work with Dart Dev Compiler.