fix(DomRenderer): correctly handle namespaced attributes by vicb · Pull Request #6363 · angular/angular

vicb · 2016-01-08T22:35:48Z

This PR contains the fixes in #5989 rebased on #5993.

tbosch · 2016-01-21T00:18:14Z

modules/angular2/test/platform/dom/dom_renderer_integration_spec.ts

Could you move these tests into linker/integration_spec?

Guard via if (DOM.supportsDOMEvents()) {

rkirov · 2016-01-25T18:05:38Z

is this ready for merge? pls remove clean-up if so and make sure travis is green?

alexeagle · 2016-01-28T17:43:54Z

Ping! remove cleanup label when you are ready to merge

alexeagle · 2016-02-03T13:56:27Z

@vicb is this ready to merge?

gkalpak · 2016-02-08T07:40:53Z

modules/angular2/test/core/linker/integration_spec.ts

Does value need to be an input ?

vicb · 2016-02-09T17:59:41Z

The PR is rebased and ready to merge

mary-poppins · 2016-02-10T22:32:41Z

Merging PR #6363 on behalf of @btford to branch presubmit-btford-pr-6363.

#6363

btford · 2016-02-11T21:55:34Z

There was an issue syncing this. Once the issue is confirmed to be resolved, I can try syncing it again.

vicb · 2016-02-12T19:49:59Z

The issue should be resolved now

mary-poppins · 2016-02-17T00:44:38Z

Merging PR #6363 on behalf of @btford to branch presubmit-btford-pr-6363.

btford · 2016-02-17T00:44:54Z

Thanks for your help on this, @vicb!

matsko · 2016-02-20T00:30:34Z

Landed as c6afea6

angular-automatic-lock-bot · 2019-09-08T19:22:42Z

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

_{This action has been performed automatically by a bot.}

googlebot added the cla: yes label Jan 8, 2016

vicb assigned tbosch Jan 8, 2016

vicb added the action: review The PR is still awaiting reviews from at least one requested reviewer label Jan 8, 2016

vicb force-pushed the 0108-atns branch from 45a61d6 to 345007a Compare January 20, 2016 00:17

tbosch reviewed Jan 21, 2016
View reviewed changes

tbosch added action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews pr_state: LGTM and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Jan 21, 2016

vicb force-pushed the 0108-atns branch 2 times, most recently from 514a26e to f32eed6 Compare January 21, 2016 18:45

vicb added the action: merge The PR is ready for merge by the caretaker label Jan 21, 2016

gkalpak reviewed Feb 8, 2016
View reviewed changes

modules/angular2/test/core/linker/integration_spec.ts Outdated

Copy link
Copy Markdown

Member

gkalpak Feb 8, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does value need to be an input ?

vicb force-pushed the 0108-atns branch 3 times, most recently from 04d853e to 5e395cf Compare February 9, 2016 17:31

vicb removed the action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews label Feb 9, 2016

btford added the zomg_admin: do merge label Feb 10, 2016

mary-poppins removed the zomg_admin: do merge label Feb 10, 2016

mhevery closed this in 61cf499 Feb 10, 2016

mhevery pushed a commit that referenced this pull request Feb 10, 2016

61cf499 fix(DomRenderer): correctly handle namespaced attributes Closes

4c8997d

#6363

mhevery pushed a commit that referenced this pull request Feb 10, 2016

61cf499 fix(DomRenderer): correctly handle namespaced attributes Closes

fbc9c83

#6363

btford reopened this Feb 11, 2016

btford mentioned this pull request Feb 11, 2016

Provide support for SVG foreignObject by adding xhtml namespace #6192

Closed

btford assigned vicb and unassigned tbosch Feb 11, 2016

btford added action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews and removed action: merge The PR is ready for merge by the caretaker pr_state: LGTM labels Feb 11, 2016

vicb force-pushed the 0108-atns branch from 5e395cf to 245c77b Compare February 11, 2016 22:52

fix(DomRenderer): correctly handle namespaced attributes

0acf7d9

vicb force-pushed the 0108-atns branch from 245c77b to 0acf7d9 Compare February 11, 2016 23:30

vicb added action: merge The PR is ready for merge by the caretaker and removed action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews labels Feb 12, 2016

btford added the zomg_admin: do merge label Feb 17, 2016

mary-poppins removed the zomg_admin: do merge label Feb 17, 2016

btford added the pr_state: LGTM label Feb 17, 2016

matsko closed this Feb 20, 2016

vicb deleted the 0108-atns branch June 23, 2016 17:43

angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 8, 2019

Conversation

vicb commented Jan 8, 2016

Uh oh!

tbosch Jan 21, 2016

Choose a reason for hiding this comment

Uh oh!

tbosch Jan 21, 2016

Choose a reason for hiding this comment

Uh oh!

rkirov commented Jan 25, 2016

Uh oh!

alexeagle commented Jan 28, 2016

Uh oh!

alexeagle commented Feb 3, 2016

Uh oh!

gkalpak Feb 8, 2016

Choose a reason for hiding this comment

Uh oh!

vicb commented Feb 9, 2016

Uh oh!

mary-poppins commented Feb 10, 2016

Uh oh!

btford commented Feb 11, 2016

Uh oh!

vicb commented Feb 12, 2016

Uh oh!

mary-poppins commented Feb 17, 2016

Uh oh!

btford commented Feb 17, 2016

Uh oh!

matsko commented Feb 20, 2016

Uh oh!

angular-automatic-lock-bot bot commented Sep 8, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

9 participants