tools(public_api): add a test verifying the public api of core#6309
Closed
vsavkin wants to merge 1 commit intoangular:masterfrom
Closed
tools(public_api): add a test verifying the public api of core#6309vsavkin wants to merge 1 commit intoangular:masterfrom
vsavkin wants to merge 1 commit intoangular:masterfrom
Conversation
vsavkin
added
the
action: review
vsavkin
force-pushed
the
public_api_spec
branch
5 times, most recently
from
ae92f75 to
68f2140
Compare
jeffbcross
added
pr_state: LGTM
action: merge
Contributor
|
@vsavkin looks good but needs rebase |
jeffbcross
added
action: cleanup
vsavkin
force-pushed
the
public_api_spec
branch
from
68f2140 to
9eb7e7d
Compare
vsavkin
added
action: merge
|
Merging PR #6309 on behalf of @rkirov to branch presubmit-rkirov-pr-6309. |
Contributor
|
looks like needs rebasing, js tests are failing |
vsavkin
force-pushed
the
public_api_spec
branch
from
9eb7e7d to
9f6c16a
Compare
Contributor
Author
|
@rkirov rebased |
|
Merging PR #6309 on behalf of @alexeagle to branch presubmit-alexeagle-pr-6309. |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a new gulp task
check-public-api. The task checks the public API of main barrels using https://github.com/angular/ts-api-guardian.