-
Notifications
You must be signed in to change notification settings - Fork 27.2k
Typings cleanup #6267
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Typings cleanup #6267
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,12 +1,12 @@ | ||
| { | ||
| "version": "v4", | ||
| "repo": "angular/DefinitelyTyped", | ||
| "repo": "DefinitelyTyped/DefinitelyTyped", | ||
| "ref": "master", | ||
| "path": "typings", | ||
| "bundle": "typings/tsd.d.ts", | ||
| "installed": { | ||
| "angularjs/angular.d.ts": { | ||
| "commit": "746b9a892629060bc853e792afff536e0ec4655e" | ||
| "commit": "6eebd5e90a1cbd6b47b0705ba72dbcd5baf846f3" | ||
| } | ||
| } | ||
| } | ||
This file was deleted.
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,7 +1,52 @@ | ||
| /** | ||
| * Declarations angular depends on for compilation to ES6. | ||
| * This file is also used to propagate our transitive typings | ||
| * to users. | ||
| * Subset of es6-shim typings. | ||
| * Angular should not require use of ES6 runtime but some API usages are already present. | ||
| * See https://github.com/angular/angular/issues/5242 | ||
| * TODO(alexeagle): remove methods below which may not be present in targeted browser | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Not sure what you are trying to say with that TODO. We are targetting IE9 and it doesn't have any of those.
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. so maybe the TODO is remove all of these - but I don't imagine we will really do that?
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @mhevery FYI |
||
| */ | ||
| /// <reference path="../typings/es6-shim/es6-shim.d.ts"/> | ||
| /// <reference path="./globals-es6.d.ts"/> | ||
|
|
||
| declare type PromiseConstructor = typeof Promise; | ||
|
|
||
| interface String { | ||
| /** | ||
| * Returns true if the sequence of elements of searchString converted to a String is the | ||
| * same as the corresponding elements of this object (converted to a String) starting at | ||
| * position. Otherwise returns false. | ||
| */ | ||
| startsWith(searchString: string, position?: number): boolean; | ||
|
|
||
| /** | ||
| * Returns true if the sequence of elements of searchString converted to a String is the | ||
| * same as the corresponding elements of this object (converted to a String) starting at | ||
| * endPosition – length(this). Otherwise returns false. | ||
| */ | ||
| endsWith(searchString: string, endPosition?: number): boolean; | ||
| } | ||
| interface Array<T> { | ||
| /** | ||
| * Returns the value of the first element in the array where predicate is true, and undefined | ||
| * otherwise. | ||
| * @param predicate find calls predicate once for each element of the array, in ascending | ||
| * order, until it finds one where predicate returns true. If such an element is found, find | ||
| * immediately returns that element value. Otherwise, find returns undefined. | ||
| * @param thisArg If provided, it will be used as the this value for each invocation of | ||
| * predicate. If it is not provided, undefined is used instead. | ||
| */ | ||
| find(predicate: (value: T, index: number, obj: Array<T>) => boolean, thisArg?: any): T; | ||
| /** | ||
| * Returns the this object after filling the section identified by start and end with value | ||
| * @param value value to fill array section with | ||
| * @param start index to start filling the array at. If start is negative, it is treated as | ||
| * length+start where length is the length of the array. | ||
| * @param end index to stop filling the array at. If end is negative, it is treated as | ||
| * length+end. | ||
| */ | ||
| fill(value: T, start?: number, end?: number): T[]; | ||
| } | ||
| interface NumberConstructor { | ||
| /** | ||
| * Returns true if the value passed is an integer, false otherwise. | ||
| * @param number A numeric value. | ||
| */ | ||
| isInteger(number: number): boolean; | ||
| } | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,30 +1,33 @@ | ||
| { | ||
| "version": "v4", | ||
| "repo": "angular/DefinitelyTyped", | ||
| "repo": "DefinitelyTyped/DefinitelyTyped", | ||
| "ref": "master", | ||
| "path": "typings", | ||
| "bundle": "typings/tsd.d.ts", | ||
| "installed": { | ||
| "es6-shim/es6-shim.d.ts": { | ||
| "commit": "4b36b94d5910aa8a4d20bdcd5bd1f9ae6ad18d3c" | ||
| "es6-promise/es6-promise.d.ts": { | ||
| "commit": "6eebd5e90a1cbd6b47b0705ba72dbcd5baf846f3" | ||
| }, | ||
| "es6-collections/es6-collections.d.ts": { | ||
| "commit": "6eebd5e90a1cbd6b47b0705ba72dbcd5baf846f3" | ||
| }, | ||
| "hammerjs/hammerjs.d.ts": { | ||
| "commit": "22c44d95912a07f81c103a694330b15b92f7cb40" | ||
| "commit": "6eebd5e90a1cbd6b47b0705ba72dbcd5baf846f3" | ||
| }, | ||
| "jasmine/jasmine.d.ts": { | ||
| "commit": "4b36b94d5910aa8a4d20bdcd5bd1f9ae6ad18d3c" | ||
| "commit": "6eebd5e90a1cbd6b47b0705ba72dbcd5baf846f3" | ||
| }, | ||
| "node/node.d.ts": { | ||
| "commit": "51738fdf1643d269067861b405e87503b7479236" | ||
| "commit": "6eebd5e90a1cbd6b47b0705ba72dbcd5baf846f3" | ||
| }, | ||
| "selenium-webdriver/selenium-webdriver.d.ts": { | ||
| "commit": "be0b6b394f77a59e192ad7cfec18078706e44db5" | ||
| "commit": "6eebd5e90a1cbd6b47b0705ba72dbcd5baf846f3" | ||
| }, | ||
| "zone/zone.d.ts": { | ||
| "commit": "31e7317c9a0793857109236ef7c7f223305a8aa9" | ||
| "zone.js/zone.js.d.ts": { | ||
| "commit": "6eebd5e90a1cbd6b47b0705ba72dbcd5baf846f3" | ||
| }, | ||
| "angular-protractor/angular-protractor.d.ts": { | ||
| "commit": "4207593c012565a7ea800ed861ffbe5011e7a501" | ||
| "commit": "6eebd5e90a1cbd6b47b0705ba72dbcd5baf846f3" | ||
| } | ||
| } | ||
| } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no more forks!