X Tutup
Skip to content

fix(benchpress): fix flake #6161

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
hankduan wants to merge 1 commit into from
Closed

fix(benchpress): fix flake #6161

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion modules/benchpress/src/firefox_extension/lib/main.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@ mod.PageMod({
contentScriptFile: data.url('installed_script.js'),
onAttach: worker => {
worker.port.on('startProfiler',
(timeStarted) => profiler.start(/* = profiler memory */ 1000000, 0.1,
(timeStarted) => profiler.start(/* = profiler memory */ 3000000, 0.1,
['leaf', 'js', 'stackwalk', 'gc'], timeStarted));
worker.port.on('stopProfiler', () => profiler.stop());
worker.port.on('getProfile',
Expand Down
1 change: 1 addition & 0 deletions modules/benchpress/test/firefox_extension/spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,7 @@ describe('firefox extension', function() {
browser.executeScript('window.startProfiler()')
.then(function() { console.log('started measuring perf'); });

browser.executeAsyncScript('setTimeout(arguments[0], 1000);');
browser.executeScript('window.forceGC()');

browser.executeAsyncScript('var cb = arguments[0]; window.getProfile(cb);')
Expand Down
5 changes: 1 addition & 4 deletions scripts/ci/test_e2e_js.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,8 +30,5 @@ fi

./node_modules/.bin/protractor protractor-js.conf.js $OPTIONS
./node_modules/.bin/protractor protractor-js.conf.js $OPTIONS --benchmark --dryrun
# TODO(tbosch): tests for benchpress on firefox are disabled
# as they are very flake. Enable once https://github.com/angular/angular/issues/5611
# is resolved.
# ./node_modules/.bin/protractor dist/js/cjs/benchpress/test/firefox_extension/conf.js
./node_modules/.bin/protractor dist/js/cjs/benchpress/test/firefox_extension/conf.js

X Tutup