X Tutup
Skip to content

fix(benchpress): fix flake#6161

Closed
hankduan wants to merge 1 commit intoangular:masterfrom
hankduan:flake
Closed

fix(benchpress): fix flake#6161
hankduan wants to merge 1 commit intoangular:masterfrom
hankduan:flake

Conversation

@hankduan
Copy link
Copy Markdown
Contributor

memory was not allocated to be high enough, resulting in partial results to be
clipped, and therefore failing the assertions. Also created a longer script call so it's harder to miss the script via firefox's polling mechanism.

@hankduan
Copy link
Copy Markdown
Contributor Author

Ran the test 30 times by adding the following to test_e2e_js.sh:

for i in {1..30}
do
  ./node_modules/.bin/protractor dist/js/cjs/benchpress/test/firefox_extension/conf.js
done

There was no failure. I'm going to do more iterations to confirm.

@hankduan hankduan force-pushed the flake branch 3 times, most recently from 7e27f27 to 5f43234 Compare December 29, 2015 21:36
@hankduan
Copy link
Copy Markdown
Contributor Author

The flake should be gone now. Ran the test against the spec 100 times without failure: https://travis-ci.org/hankduan/angular/jobs/99329616

@tbosch
Copy link
Copy Markdown
Contributor

tbosch commented Dec 29, 2015

Thanks! Could you also include the change to test_e2e_js.sh that runs these tests again?

memory was not allocated to be high enough, resulting in partial results to be
clipped, and therefore failing the assertions
@hankduan
Copy link
Copy Markdown
Contributor Author

Done

@hankduan hankduan added the action: merge The PR is ready for merge by the caretaker label Dec 30, 2015
@mary-poppins
Copy link
Copy Markdown

Merging PR #6161 on behalf of @alxhub to branch presubmit-alxhub-pr-6161.

@angular-automatic-lock-bot
Copy link
Copy Markdown

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 7, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

action: merge The PR is ready for merge by the caretaker cla: yes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

X Tutup