X Tutup
Skip to content

fix(DomRenderer): correctly handle namespaced attributes#5989

Closed
vicb wants to merge 1 commit intoangular:masterfrom
vicb:1217-ns
Closed

fix(DomRenderer): correctly handle namespaced attributes#5989
vicb wants to merge 1 commit intoangular:masterfrom
vicb:1217-ns

Conversation

@vicb
Copy link
Copy Markdown
Contributor

@vicb vicb commented Dec 17, 2015

fixes #5548
fixes #5034
fixes #6255

Contains 2 fixes:

  • namespaced attributes were not created properly when a view got instantiated,
  • attribute binding did not support namespaces.

@vicb vicb force-pushed the 1217-ns branch 2 times, most recently from b5c04f4 to 391f9bd Compare December 17, 2015 22:28
@vicb vicb added action: review The PR is still awaiting reviews from at least one requested reviewer comp: core/view/compiler labels Dec 17, 2015
@tbosch
Copy link
Copy Markdown
Contributor

tbosch commented Dec 18, 2015

Let's wait with this PR until my performance PR is in: #5993

On Thu, Dec 17, 2015 at 2:59 PM Victor Berchet notifications@github.com
wrote:

Assigned #5989 #5989 to @tbosch
https://github.com/tbosch.


Reply to this email directly or view it on GitHub
#5989 (comment).

@gionkunz
Copy link
Copy Markdown
Contributor

@vicb, will this also fix the effect of sibling attributes
of a namespaced attribute were created with a wrong namespace?

<svg>
  <image x="20" y="20" width="300" height="80"  xlink:href="image.png" />
</svg>

Using beta.0 the above example results in the attributes x, y, width, height and xlink:href being created with the namespace http://www.w3.org/1999/xlink.

@angular-automatic-lock-bot
Copy link
Copy Markdown

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 11, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

action: review The PR is still awaiting reviews from at least one requested reviewer cla: yes

Projects

None yet

4 participants

X Tutup