Still to do:

• web worker tests are failing. Need to create angular2/platform/testing/web_worker.ts or some such and use it there instead.
• dart package angular2_testing is not yet updated.
• test.unit.cjs is still failing - they're never set up with base providers. Figure out where to do this and what providers they should have.

This is now squashed and has a real commit message noting the breaking change. Waiting for Travis, but all the unit test suites are passing locally. Ready for review!

Note that this will require a change in g3 to remove a use of createTestInjectorWithRuntimeCompiler and createTestInjector.

I'm a bit confused because I'm not sure what "platform providers" are.

I know what PLATFORM_DIRECTIVES are. I know what PLATFORM_PIPES are. We need to account for both of these during our testing ... both to load them by default perhaps AND to facilitate mocking them under test.

We have a mechanism for setting up providers and for overloading the (implicit) providers that A2 registers by default.

platform providers is analogous to the terminology we use in platform(<providers>).application(<providers>).boostrap(<component>).

The PLATFORM_DIRECTIVES and PLATFORM_PIPES are now loaded by default if you set up with angular2/plaform/testing/browser.

The terminology challenge for me is that provider != directive != pipe.

I must have missed something along the way. I hadn't realized that directives, components, and pipe are all "provided" ... like anything else I toss in the injector. I thought they went somewhere special with their own namespace.

This also means that, withing the same injector, I can replace any directive by writing

provide(SomeDirective, {useClass: MyAlternativeDirective})

I can do that in my production code, not just in tests.

Does that sound right? I haven't tried it.

Is it save to assume that you reset the "standard directives set" if I mock one of them out during a test?

Suppose I spy on the DatePipe or on NgModel. That goes away next test, yes?

Yes, everything is reset between tests.

For the record, based on our conversation, I had the wrong mental model.

Here is my revised understanding ... which we hope conforms to reality.

Providers, Directives, and Pipes are their own categories. There are good reasons why we have separate providers, directives, and pipes arrays in metadata.

The "provider" with the token "PLATFORM_DIRECTIVES" is an array of directives that Angular stashes in the top injector.

When Angular gets ready to look for directives in a template, it combines what we list in our directives metadata array with the platform directives that it retrieved from the injector under the "PLATFORM_DIRECTIVES" token.

The test apparatus described in this PR is a way to configure the platform common providers and platform directives for the test suite.

Dear merge-master:

This will require a small change to g3. Here's a doc with all the info: https://docs.google.com/document/d/10N5YrdavEECZt-WJhYw7967RFrzF7tmLiihHXAhKxc8

After a talk with users teams, it sounds like we should wait until after the holidays to make any sort of changes, so consider this ready but waiting.

the doc says "We should wait until after the holiday freeze to be sure the
ACX team is around" - so we should wait, right?
Also, https://rotation.googleplex.com/#rotation?id=5710658318368768
(there seems to be a rumor that I'm caretaker?)

On Mon, Dec 21, 2015 at 3:05 PM Julie Ralph notifications@github.com
wrote:

Dear merge-master: @alexeagle https://github.com/alexeagle

This is OKd by Tobias to go in now, and ready to merge! It will require a
sall change to g3. Here's a doc with all the info:
https://docs.google.com/document/d/10N5YrdavEECZt-WJhYw7967RFrzF7tmLiihHXAhKxc8

—
Reply to this email directly or view it on GitHub
#5975 (comment).

Yes! Sorry, my comment was edited to say that but edits don't get out to emails.

I did not start the rumor :)

FYI - this is now rebased on top of the recent freezing code changes.

Test failures are due to new saucelabs_required test target. @mgol do you happen to have time to take a look and see if these are legitimate? I'm surprised by all the zone failures.

The failures on FireFox and IE were due to a global setup on load in testing utils BrowserDetection. Because the new test platform initializer, which set up the DOM, was not called until after files were loaded, BrowserDetection broke. This is now fixed.

Merging PR #5975 on behalf of @rkirov to branch presubmit-rkirov-pr-5975.

Did this made it to beta.2? Because I cannot find neither of TEST_BROWSER_PLATFORM_PROVIDERS, TEST_BROWSER_APPLICATION_PROVIDERS nor angular2/platform/testing/browser in the testing.dev.js bundle.
@juliemr

@rolandjitsu see #6771

@pkozlowski-opensource thanks.

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

_{This action has been performed automatically by a bot.}