X Tutup
Skip to content

docs: fix typos#5943

Closed
flyyang wants to merge 1 commit intoangular:masterfrom
flyyang:master
Closed

docs: fix typos#5943
flyyang wants to merge 1 commit intoangular:masterfrom
flyyang:master

Conversation

@flyyang
Copy link
Copy Markdown
Contributor

@flyyang flyyang commented Dec 16, 2015

See the changes

@googlebot
Copy link
Copy Markdown

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please let us know the company's name.

@flyyang
Copy link
Copy Markdown
Contributor Author

flyyang commented Dec 16, 2015

I signed it!

@googlebot
Copy link
Copy Markdown

CLAs look good, thanks!

@robwormald
Copy link
Copy Markdown
Contributor

@flyyang thanks for the PR. could you update your commit message to conform to the guidelines mentioned here? thanks!
https://github.com/angular/angular/blob/master/CONTRIBUTING.md#-commit-message-guidelines

@flyyang
Copy link
Copy Markdown
Contributor Author

flyyang commented Dec 16, 2015

All these changes should go docs or style or fix?

@0x-r4bbit
Copy link
Copy Markdown
Contributor

I'd go with docs: .... here. Fixes are really for bug fixes. Just don't specify a scope, since you touched docs comments but also test specs.

Couple of typos fixed:
- occuring -> occurring
- imlement -> implement
- idenitifer -> identifer
etc...
@flyyang
Copy link
Copy Markdown
Contributor Author

flyyang commented Dec 16, 2015

Hi @PascalPrecht . Does the update suits our conventions. Anything else?

@pkozlowski-opensource pkozlowski-opensource added pr_state: LGTM action: merge The PR is ready for merge by the caretaker labels Dec 16, 2015
@pkozlowski-opensource pkozlowski-opensource changed the title fix some type docs: fix typos Dec 17, 2015
@mary-poppins
Copy link
Copy Markdown

Merging PR #5943 on behalf of @alexeagle to branch presubmit-alexeagle-pr-5943.

@angular-automatic-lock-bot
Copy link
Copy Markdown

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 7, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

action: merge The PR is ready for merge by the caretaker cla: yes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants

X Tutup