X Tutup
Skip to content

feat(test): allow tests to specify the platform and application#5937

Closed
juliemr wants to merge 2 commits intoangular:masterfrom
juliemr:test-with-bundles-2
Closed

feat(test): allow tests to specify the platform and application#5937
juliemr wants to merge 2 commits intoangular:masterfrom
juliemr:test-with-bundles-2

Conversation

@juliemr
Copy link
Copy Markdown
Member

@juliemr juliemr commented Dec 16, 2015

Note: This is on top of #5920

@juliemr
refactor(testing): move common testing logic into test_injector
3e3b221 
Before, all test framework wrappers (internal for dart and js/ts,
angular2_test for dart and testing for js/ts) had similar logic to
keep track of current global test injector and test provider list.
This change wraps that logic into one class managed by the test
injector.
@juliemr juliemr added state: WIP area: testing Issues related to Angular testing features, such as TestBed labels Dec 16, 2015
@pkozlowski-opensource
Copy link
Copy Markdown
Member

pkozlowski-opensource commented Dec 16, 2015

@juliemr Dart-related failures on TravisCI seem legit

@juliemr juliemr mentioned this pull request Dec 16, 2015
Closed
@juliemr
Copy link
Copy Markdown
Member Author

juliemr commented Dec 16, 2015

@pkozlowski-opensource agreed, looking into them. Dart is unhappy about const stuff.

@juliemr
WIP - feat(test): allow tests to specify the platform and application…
5e5f534 
… providers used

Part I - clean up and make the TestInjector object allow changes.
@juliemr juliemr force-pushed the test-with-bundles-2 branch from b9092d0 to 5e5f534 Compare December 16, 2015 20:24
@juliemr
Copy link
Copy Markdown
Member Author

juliemr commented Dec 16, 2015

Status update: I was hoping to add PLATFORM_DIRECTIVES to the test bindings in a way that doesn't introduce any breaking changes to tests, but it looks like that would be very convoluted to get working with the current set of internal tests (including the test.server.dart tests which can't include dart:html anywhere). I'm working on a minimal, simple breaking change proposal.

@juliemr
Copy link
Copy Markdown
Member Author

juliemr commented Dec 17, 2015

New proposal is here: #5975

Closing this one for now, since it's insufficient.

@juliemr juliemr closed this Dec 17, 2015
@angular-automatic-lock-bot
Copy link
Copy Markdown

angular-automatic-lock-bot bot commented Sep 7, 2019

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 7, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

@alxhub alxhub

Labels

area: testing Issues related to Angular testing features, such as TestBed cla: yes state: WIP

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@juliemr @pkozlowski-opensource @alxhub @googlebot
X Tutup