X Tutup
Skip to content

fix(ChangeDetection): chain expressions evaluate to the last expressi…#5892

Closed
vicb wants to merge 1 commit intoangular:masterfrom
vicb:1214-cd
Closed

fix(ChangeDetection): chain expressions evaluate to the last expressi…#5892
vicb wants to merge 1 commit intoangular:masterfrom
vicb:1214-cd

Conversation

@vicb
Copy link
Copy Markdown
Contributor

@vicb vicb commented Dec 15, 2015

…on (codegen)

fixes #4782

@vicb vicb added type: bug/fix comp: core/change_detection action: review The PR is still awaiting reviews from at least one requested reviewer labels Dec 15, 2015
@IgorMinar IgorMinar added this to the beta.1 milestone Dec 15, 2015
@IgorMinar
Copy link
Copy Markdown
Contributor

bumping to beta.1 since this is a relatively risky change.

@vsavkin
Copy link
Copy Markdown
Contributor

vsavkin commented Dec 15, 2015

modules/angular2/test/core/linker/integration_spec.ts does not run with transformers.

I think a better place to test this behavior is: core/change_detection/change_detector_spec.ts, which runs in both modes.

  • Add a test to change_detector_spec.ts
  • Undo your change in linker/integration_spec.ts

But the prod change looks good.

@vsavkin vsavkin added action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Dec 15, 2015
@vsavkin vsavkin assigned vicb and unassigned vsavkin Dec 15, 2015
@vsavkin vsavkin added pr_state: LGTM and removed action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews labels Dec 15, 2015
@vicb vicb added the action: merge The PR is ready for merge by the caretaker label Dec 15, 2015
@IgorMinar IgorMinar modified the milestone: beta.1 Dec 15, 2015
@mary-poppins
Copy link
Copy Markdown

Merging PR #5892 on behalf of @alxhub to branch presubmit-alxhub-pr-5892.

@mary-poppins
Copy link
Copy Markdown

Merging PR #5892 on behalf of @rkirov to branch presubmit-rkirov-pr-5892.

@mhevery mhevery closed this in 933a911 Jan 12, 2016
@vicb vicb deleted the 1214-cd branch June 23, 2016 17:43
@angular-automatic-lock-bot
Copy link
Copy Markdown

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

action: merge The PR is ready for merge by the caretaker cla: yes type: bug/fix

Projects

None yet

Development

Successfully merging this pull request may close these issues.

returning false from event no longer cancels prevent default

7 participants

X Tutup