X Tutup
Skip to content

chore: cleanup & reformat files#5880

Closed
cironunes wants to merge 1 commit intoangular:masterfrom
cironunes:cleanup
Closed

chore: cleanup & reformat files#5880
cironunes wants to merge 1 commit intoangular:masterfrom
cironunes:cleanup

Conversation

@cironunes
Copy link
Copy Markdown
Member

@cironunes cironunes commented Dec 14, 2015

No description provided.

vicb
vicb reviewed Dec 14, 2015
View reviewed changes
tools/broccoli/angular_builder.ts Outdated
Copy link
Copy Markdown
Contributor

@vicb vicb Dec 14, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems like clang does not know how to format type alias: https://travis-ci.org/angular/angular/jobs/96761613#L291

Could you please open an issue on https://github.com/angular/clang-format

@vicb
Copy link
Copy Markdown
Contributor

vicb commented Dec 14, 2015

The change in angular_builder is related to clang and should be reverted (please open an issue against clang). Thanks.

@cironunes cironunes mentioned this pull request Dec 14, 2015
Closed
@IgorMinar IgorMinar added pr_state: LGTM action: merge The PR is ready for merge by the caretaker labels Dec 15, 2015
@IgorMinar IgorMinar added this to the beta.0 milestone Dec 15, 2015
@mary-poppins
Copy link
Copy Markdown

mary-poppins commented Dec 15, 2015

Merging PR #5880 on behalf of @alexeagle to branch presubmit-alexeagle-pr-5880.

@mary-poppins
Copy link
Copy Markdown

mary-poppins commented Dec 15, 2015

Merging PR #5880 on behalf of @alexeagle to branch presubmit-alexeagle-pr-5880.

@mhevery mhevery closed this in e891bae Dec 15, 2015
@angular-automatic-lock-bot
Copy link
Copy Markdown

angular-automatic-lock-bot bot commented Sep 7, 2019

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 7, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

action: merge The PR is ready for merge by the caretaker cla: yes

Projects

None yet

Milestone

beta.0

Development

Successfully merging this pull request may close these issues.

6 participants

@cironunes @vicb @mary-poppins @alexeagle @IgorMinar @googlebot
X Tutup