X Tutup
Skip to content

docs(bundles): document existing bundles and their usage#5878

Closed
pkozlowski-opensource wants to merge 1 commit intoangular:masterfrom
pkozlowski-opensource:bundles_doc
Closed

docs(bundles): document existing bundles and their usage#5878
pkozlowski-opensource wants to merge 1 commit intoangular:masterfrom
pkozlowski-opensource:bundles_doc

Conversation

@pkozlowski-opensource
Copy link
Copy Markdown
Member

Closes #5777

@pkozlowski-opensource pkozlowski-opensource added the action: review The PR is still awaiting reviews from at least one requested reviewer label Dec 14, 2015
@pkozlowski-opensource pkozlowski-opensource added this to the beta.0 milestone Dec 14, 2015
@pkozlowski-opensource pkozlowski-opensource force-pushed the bundles_doc branch 2 times, most recently from 3f24464 to c2d3a24 Compare December 14, 2015 16:16
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Duplicate angular2/platform/browser, also in the following tables.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

on-line -> online

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider using a common punctuation technique for these bullet items, such as a comma:
If you write ES5,
If you experiment ... or similar, (with no punctuation here it is harder to read "or similar use" vs "or similar, use")
If you use ... or WebPack, (this one used a dash)
For all of the above cases,

@IgorMinar
Copy link
Copy Markdown
Contributor

@pkozlowski-opensource THIS IS AN AWESOME DOC! THANK YOU SO MUCH!

@pkozlowski-opensource
Copy link
Copy Markdown
Member Author

THANK YOU @IgorMinar :-) Now off to fixing all the comments from the awesome and detailed reviews! Thank you all guys!

@fxck
Copy link
Copy Markdown

fxck commented Dec 14, 2015

Not sure if it's related to this particular doc, but I've seen @pkozlowski-opensource and @robwormald mention rollup quite a few times. And I suppose there will be angular 2 recommended way to go about bundling, is it rollup? Is it something else? Wouldn't it be worth mentioning in this doc? Or is there absolutely nothing worth mentioning yet?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

action: merge The PR is ready for merge by the caretaker cla: yes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

document bundle contents, formats, and intended usage
X Tutup