Closed
Conversation
vicb
added
action: review
Member
There was a problem hiding this comment.
Shouldn't directive be component in this block-comment ?
Contributor
Author
There was a problem hiding this comment.
Yep, thanks for catching
moduleId is only used by components to resolve urls. Directives have no templates and do not need moduleId.
Contributor
|
lgtm |
Contributor
|
I don't think that @tbosch will get to review this, but it looks go to me, so let's merge it - if issues are identified after merge we'll deal with them. |
IgorMinar
added
pr_state: LGTM
action: merge
|
Merging PR #5873 on behalf of @alexeagle to branch presubmit-alexeagle-pr-5873. |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
moduleId is only used by components to resolve urls.
Directives have no templates and do not need moduleId.