X Tutup
Skip to content

build(publish.sh): do not error when tmp/code.angularjs.org already e…#5872

Closed
IgorMinar wants to merge 1 commit intoangular:masterfrom
IgorMinar:publish.sh-no-clone
Closed

build(publish.sh): do not error when tmp/code.angularjs.org already e…#5872
IgorMinar wants to merge 1 commit intoangular:masterfrom
IgorMinar:publish.sh-no-clone

Conversation

@IgorMinar
Copy link
Copy Markdown
Contributor

…xists

I'm not sure what's the best way to update the shallow repo and I'm in a state where there is nothing to be
updated so I'll revisit the proper fix the next time I'm doing a release unless someone beats me to it.

@IgorMinar IgorMinar added this to the beta.0 milestone Dec 14, 2015
@IgorMinar
Copy link
Copy Markdown
Contributor Author

without this change, I have to manually delete the code.angularjs.org clone from the tmp dir, which really sucks, since it takes quite a while for that repo to be cloned.

@vicb
Copy link
Copy Markdown
Contributor

vicb commented Dec 14, 2015

Would it makes sense to exit after the TODO msg unless a --force parameter is passed to the script ?
(disclaimer: I don't know this script)

@IgorMinar
Copy link
Copy Markdown
Contributor Author

I improved the todo message to make it more actionable.

I don't think that we need a to exit or use --force, it's easy to recover from errors and errors have no impact.

…xists

I'm not sure what's the best way to update the shallow repo and I'm in a state where there is nothing to be
updated so I'll revisit the proper fix the next time I'm doing a release unless someone beats me to it.
@IgorMinar IgorMinar added action: merge The PR is ready for merge by the caretaker zomg_admin: do merge labels Dec 15, 2015
@mary-poppins
Copy link
Copy Markdown

User @IgorMinar does not have PR merging privileges.

1 similar comment
@mary-poppins
Copy link
Copy Markdown

User @IgorMinar does not have PR merging privileges.

@mary-poppins
Copy link
Copy Markdown

Merging PR #5872 on behalf of @alexeagle to branch presubmit-alexeagle-pr-5872.

@angular-automatic-lock-bot
Copy link
Copy Markdown

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 7, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

action: merge The PR is ready for merge by the caretaker cla: yes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

X Tutup