X Tutup
Skip to content

fix(changelog): fix rxjs operator import paths#5864

Closed
tamascsaba wants to merge 1 commit intoangular:masterfrom
tamascsaba:master
Closed

fix(changelog): fix rxjs operator import paths#5864
tamascsaba wants to merge 1 commit intoangular:masterfrom
tamascsaba:master

Conversation

@tamascsaba
Copy link
Copy Markdown
Contributor

I have changed the wrong import folder.

@robwormald
Copy link
Copy Markdown
Contributor

this was technically correct at the time this entry was added to the changelog, although your corrections now are correct :D - could you correct the commit message to say something like fix(changelog): fix rxjs operator import paths

@gkalpak
Copy link
Copy Markdown
Member

gkalpak commented Dec 14, 2015

Shouldn't it rather be docs(changelog): ... ?

@tamascsaba tamascsaba changed the title fix(changelog): fix rxjs ovservable fix(changelog): fix rxjs operator import paths Dec 14, 2015
@tamascsaba
Copy link
Copy Markdown
Contributor Author

Thanks :), I modified my commit message and P.M title too.

@vicb
Copy link
Copy Markdown
Contributor

vicb commented Dec 14, 2015

@robwormald are the changes correct in the context of alpha 48 ?

@robwormald
Copy link
Copy Markdown
Contributor

@vicb there was so much churn in the last few revs of ng2 and Rx i've honestly lost track :octocat: As far as i'm aware they were - these changes are valid for 52+

@vicb
Copy link
Copy Markdown
Contributor

vicb commented Dec 14, 2015

Not sure if I get your message ? (48 is < 52+).
Anyway feel free to add the lgtm label if this is ok.

@IgorMinar
Copy link
Copy Markdown
Contributor

we should document the current state, so the PR is good. if someone cares about the instructions for a48 they can look at the old version of this file.

@IgorMinar IgorMinar added pr_state: LGTM action: merge The PR is ready for merge by the caretaker labels Dec 15, 2015
@IgorMinar IgorMinar added this to the beta.0 milestone Dec 15, 2015
@mary-poppins
Copy link
Copy Markdown

Merging PR #5864 on behalf of @alexeagle to branch presubmit-alexeagle-pr-5864.

@angular-automatic-lock-bot
Copy link
Copy Markdown

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 7, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

action: merge The PR is ready for merge by the caretaker cla: yes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants

X Tutup