fix(public_spec): check exports of barrels instead of angular2/angular2#5841
Closed
tbosch wants to merge 1 commit intoangular:masterfrom
Closed
fix(public_spec): check exports of barrels instead of angular2/angular2#5841tbosch wants to merge 1 commit intoangular:masterfrom
tbosch wants to merge 1 commit intoangular:masterfrom
Conversation
This changes the public api spec to check each public barrel individually to make sure its API has not changed. The previous API spec has been preserved but split into respective barrels. The compiler barrel has been added to the spec, along with all of its public exports. Previously, angular2/angular2 was only exporting a handful of symbols from compiler, so there are now many more symbols being tested in the spec for compiler than previously. Part of angular#5710
|
We found a Contributor License Agreement for you (the sender of this pull request) and all commit authors, but as best as we can tell these commits were authored by someone else. If that's the case, please add them to this pull request and have them confirm that they're okay with these commits being contributed to Google. If we're mistaken and you did author these commits, just reply here to confirm. |
Contributor
Author
|
@jeffbcross is ok regarding licenses |
Contributor
Author
|
Created with @jeffbcross in pairing |
tbosch
added
pr_state: LGTM
action: merge
pkozlowski-opensource
pushed a commit
to pkozlowski-opensource/angular
that referenced
this pull request
Dec 11, 2015
This changes the public api spec to check each public barrel individually to make sure its API has not changed. The previous API spec has been preserved but split into respective barrels. The compiler barrel has been added to the spec, along with all of its public exports. Previously, angular2/angular2 was only exporting a handful of symbols from compiler, so there are now many more symbols being tested in the spec for compiler than previously. Part of angular#5710 Closes angular#5841
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This changes the public api spec to check each public barrel individually
to make sure its API has not changed. The previous API spec has been
preserved but split into respective barrels.
The compiler barrel has been added to the spec, along with all of its
public exports. Previously, angular2/angular2 was only exporting a
handful of symbols from compiler, so there are now many more symbols
being tested in the spec for compiler than previously.
Part of #5710
Supersedes #5821