fix(angular2): don't export compiler bits as public API#5828
Closed
pkozlowski-opensource wants to merge 1 commit intoangular:masterfrom
Closed
fix(angular2): don't export compiler bits as public API#5828pkozlowski-opensource wants to merge 1 commit intoangular:masterfrom
pkozlowski-opensource wants to merge 1 commit intoangular:masterfrom
Conversation
Member
Author
|
According to #5815 we shouldn't be obliged to export compiler bits from |
Member
Author
|
#5821 needs to go in first |
Contributor
|
Please change the commit message to say that these symbols can be found in |
Closes angular#5815 BREAKING CHANGE: The following symbols are not exported from angular2/angular2 any more: `UrlResolver`, `AppRootUrl`, `getUrlScheme`, `DEFAULT_PACKAGE_URL_PROVIDER`. Use imports from `angular2/compiler` instead.
pkozlowski-opensource
force-pushed
the
remove_compiler_export_from_ng2
branch
from
5b2a428 to
40f839d
Compare
Member
Author
Member
Author
|
Closing, now part of #5797 |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #5815
BREAKING CHANGE:
The following symbols are not exported from angular2/angular2 any more:
UrlResolver,AppRootUrl,getUrlScheme,DEFAULT_PACKAGE_URL_PROVIDER.