refactor(testing): move common testing logic into test_injector#5819
Closed
juliemr wants to merge 1 commit intoangular:masterfrom
Closed
refactor(testing): move common testing logic into test_injector#5819juliemr wants to merge 1 commit intoangular:masterfrom
juliemr wants to merge 1 commit intoangular:masterfrom
Conversation
juliemr
added
the
area: testing
juliemr
force-pushed
the
test-provider-config-3
branch
3 times, most recently
from
9443a4c to
2f993ba
Compare
juliemr
added
the
action: review
Member
Author
|
@vicb arbitrarily assigning you as someone who's worked with testing :) |
Member
Author
|
cc @kevmoo for a sanity check on the dart angular2_testing changes - this gets rid of reaching in to the test internals and just uses teardowns. |
Contributor
|
LGTM 😄 |
juliemr
force-pushed
the
test-provider-config-3
branch
from
2f993ba to
7dd66a3
Compare
Member
There was a problem hiding this comment.
Should _injector and _providers be denoted private ?
juliemr
force-pushed
the
test-provider-config-3
branch
from
7dd66a3 to
f66bfb7
Compare
Before, all test framework wrappers (internal for dart and js/ts, angular2_test for dart and testing for js/ts) had similar logic to keep track of current global test injector and test provider list. This change wraps that logic into one class managed by the test injector.
juliemr
force-pushed
the
test-provider-config-3
branch
from
f66bfb7 to
38c845f
Compare
vicb
added
pr_state: LGTM
and removed
action: review
|
Merging PR #5819 on behalf of @alexeagle to branch presubmit-alexeagle-pr-5819. |
This was referenced Dec 15, 2015
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before, all test framework wrappers (internal for dart and js/ts,
angular2_test for dart and testing for js/ts) had similar logic to
keep track of current global test injector and test provider list.
This change wraps that logic into one class managed by the test
injector.