build(sauce/bs): make some browsers required in CI#5795
build(sauce/bs): make some browsers required in CI#5795marclaval wants to merge 1 commit intoangular:masterfrom
Conversation
marclaval
force-pushed
the
requiredBrowserProviders
branch
6 times, most recently
from
a78bd44 to
054c53f
Compare
marclaval
added
action: review
marclaval
force-pushed
the
requiredBrowserProviders
branch
from
054c53f to
9795432
Compare
There was a problem hiding this comment.
does null stand for local browser? can you add that to the documentation in a separate PR please?
There was a problem hiding this comment.
or does it mean that we don't run that browser anywhere?
|
lgtm |
|
please fix up the docs in a separate PR |
IgorMinar
added
pr_state: LGTM
action: merge
|
Merging PR #5795 on behalf of @alexeagle to branch presubmit-alexeagle-pr-5795. |
|
Merging PR #5795 on behalf of @alexeagle to branch presubmit-alexeagle-pr-5795. |
marclaval
force-pushed
the
requiredBrowserProviders
branch
from
9795432 to
64165d3
Compare
|
Merge failed, so comments integrated here. But SauceLabs seems to have issues, the job hangs forever after running all the tests successfully. |
|
This is weird.. I've restarted the job. if that doesn't help and raw log doesn't reveal anything (sometimes travis UI doesn't show complete log), try to rebase the PR. |
marclaval
force-pushed
the
requiredBrowserProviders
branch
from
64165d3 to
65382ec
Compare
marclaval
force-pushed
the
requiredBrowserProviders
branch
from
65382ec to
e4e3f2e
Compare
|
Rebasing didn't help, but I found that the culprit was Chrome Canary (i.e. version 49) which was released 5 days ago. A new version of the Selenium drivers might be needed. |
|
great. let's get this in! |
|
Merging PR #5795 on behalf of @alxhub to branch presubmit-alxhub-pr-5795. |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
6 participants
As discussed with @IgorMinar and @juliemr , let's add the very stable browsers as required jobs in CI.
For other ones, they are kept in optional jobs. Analytics will be added later in order to have more details about them.