X Tutup
Skip to content

docs(CHANGELOG): add breaking change for NPM's peerDependencies#5747

Closed
pkozlowski-opensource wants to merge 1 commit intoangular:masterfrom
pkozlowski-opensource:peer_breaking_change
Closed

docs(CHANGELOG): add breaking change for NPM's peerDependencies#5747
pkozlowski-opensource wants to merge 1 commit intoangular:masterfrom
pkozlowski-opensource:peer_breaking_change

Conversation

@pkozlowski-opensource
Copy link
Copy Markdown
Member

@pkozlowski-opensource pkozlowski-opensource commented Dec 9, 2015

Fixes #5746

alxhub
alxhub reviewed Dec 9, 2015
View reviewed changes
CHANGELOG.md
Copy link
Copy Markdown
Member

@alxhub alxhub Dec 9, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: missing space in front of asterisk, line up intentation.

Copy link
Copy Markdown
Member Author

@pkozlowski-opensource pkozlowski-opensource Dec 9, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@alxhub I can't see spaces in front of other * in our changelog (at least not when open in my editor)

@IgorMinar
Copy link
Copy Markdown
Contributor

IgorMinar commented Dec 9, 2015

Lgtm. Was this not picked up by the change of script? Please file a bug

@pkozlowski-opensource
Copy link
Copy Markdown
Member Author

pkozlowski-opensource commented Dec 9, 2015

@IgorMinar yeh, this is due to the fact that commit was flagged as build. Will file an issue

meenie
meenie reviewed Dec 9, 2015
View reviewed changes
CHANGELOG.md Outdated
Copy link
Copy Markdown
Contributor

@meenie meenie Dec 9, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be 5.0.0-alpha.14.

@pkozlowski-opensource pkozlowski-opensource added the action: merge The PR is ready for merge by the caretaker label Dec 9, 2015
@meenie
Copy link
Copy Markdown
Contributor

meenie commented Dec 9, 2015

@pkozlowski-opensource: Actually, I messed up. rxjs@5.0.0-alpha.14 didn't come in until angular2@2.0.0-alpha.50. This is a changelog fix for 49 so it should be rxjs@5.0.0-alpha.13.

@mary-poppins
Copy link
Copy Markdown

mary-poppins commented Dec 9, 2015

Merging PR #5747 on behalf of @alexeagle to branch presubmit-alexeagle-pr-5747.

@mary-poppins
Copy link
Copy Markdown

mary-poppins commented Dec 9, 2015

Merging PR #5747 on behalf of @alexeagle to branch presubmit-alexeagle-pr-5747.

@IgorMinar IgorMinar closed this in 4e16fea Dec 10, 2015
@IgorMinar
Copy link
Copy Markdown
Contributor

IgorMinar commented Dec 10, 2015

I recreated this PR because it failed to rebase

@angular-automatic-lock-bot
Copy link
Copy Markdown

angular-automatic-lock-bot bot commented Sep 7, 2019

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 7, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

action: merge The PR is ready for merge by the caretaker cla: yes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

npm install complains about peer deps

7 participants

@pkozlowski-opensource @IgorMinar @meenie @mary-poppins @alxhub @alexeagle @googlebot
X Tutup