refactor(core): replace usages of removeChild#57203
Closed
crisbeto wants to merge 1 commit intoangular:mainfrom
Closed
refactor(core): replace usages of removeChild#57203crisbeto wants to merge 1 commit intoangular:mainfrom
crisbeto wants to merge 1 commit intoangular:mainfrom
Conversation
crisbeto
added
area: core
crisbeto
force-pushed
the
remove-child-again
branch
from
a19a358 to
8457281
Compare
Member
Author
|
Mostly passing TGP, aside from one unrelated failure and one that I'll clean up before we submit. |
crisbeto
added
action: review
pullapprove
bot
requested review from
alxhub,
jelbourn,
josephperrott and
pkozlowski-opensource
josephperrott
approved these changes
Jul 31, 2024
Member
josephperrott
left a comment
josephperrott
left a comment
There was a problem hiding this comment.
LGTM
Reviewed-for: fw-security
alxhub
approved these changes
Aug 6, 2024
Member
alxhub
left a comment
alxhub
left a comment
There was a problem hiding this comment.
Reviewed-for: global-approvers
crisbeto
added
action: merge
Member
Author
|
Will run another TGP just in case. |
These changes replace most usages of `removeChild` with `remove`. The latter has the advantage of not having to look up the `parentNode` and ensure that the child being removed actually belongs to the specific parent. The refactor should be fairly safe since all the browsers we cover support `remove`. [Something similar was done in Components](angular/components#23592) some time ago and there haven't been any bug reports as a result.
crisbeto
force-pushed
the
remove-child-again
branch
from
8457281 to
108356b
Compare
Member
Author
crisbeto
added
action: merge
thePunderWoman
pushed a commit
that referenced
this pull request
Aug 7, 2024
These changes replace most usages of `removeChild` with `remove`. The latter has the advantage of not having to look up the `parentNode` and ensure that the child being removed actually belongs to the specific parent. The refactor should be fairly safe since all the browsers we cover support `remove`. [Something similar was done in Components](angular/components#23592) some time ago and there haven't been any bug reports as a result. PR Close #57203
Contributor
|
This PR was merged into the repository by commit 513a4fe. The changes were merged into the following branches: main, 18.1.x |
nartc
added a commit
to angular-threejs/angular-three
that referenced
this pull request
Aug 13, 2024
This was affected by a recent change in Angular upstream that Angular core decides to use `element.remove()` instead of `parent.removeChild(element)`. Hence, during the unmount phase, the `parent` is never calculated and passed in. angular/angular#57203
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These changes replace most usages of
removeChildwithremove. The latter has the advantage of not having to look up theparentNodeand ensure that the child being removed actually belongs to the specific parent.The refactor should be fairly safe since all the browsers we cover support
remove. Something similar was done in Components some time ago and there haven't been any bug reports as a result.