X Tutup
Skip to content

docs(contributing.md): add docs for "build" commit type#5720

Closed
IgorMinar wants to merge 1 commit intomasterfrom
IgorMinar-patch-1-1
Closed

docs(contributing.md): add docs for "build" commit type#5720
IgorMinar wants to merge 1 commit intomasterfrom
IgorMinar-patch-1-1

Conversation

@IgorMinar
Copy link
Copy Markdown
Contributor

@IgorMinar IgorMinar commented Dec 9, 2015

Our build system is pretty complicated and we have many commits that touch it.

For this reason these kids of changes warrant its own type.

@IgorMinar
docs(contributing.md): add docs for "build" commit type
d45451b 
Our build system is pretty complicated and we have many commits that touch it.

For this reason these kids of changes warrant its own type.
@IgorMinar IgorMinar added the action: review The PR is still awaiting reviews from at least one requested reviewer label Dec 9, 2015
@jelbourn jelbourn added pr_state: LGTM action: merge The PR is ready for merge by the caretaker labels Dec 9, 2015
@mary-poppins
Copy link
Copy Markdown

mary-poppins commented Dec 9, 2015

Merging PR #5720 on behalf of @jelbourn to branch presubmit-jelbourn-pr-5720.

@jelbourn jelbourn added zomg_admin: do merge and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Dec 9, 2015
@mary-poppins
Copy link
Copy Markdown

mary-poppins commented Dec 9, 2015

Merging PR #5720 on behalf of @jelbourn to branch presubmit-jelbourn-pr-5720.

@IgorMinar IgorMinar closed this in 7d15e19 Dec 9, 2015
@petebacondarwin
Copy link
Copy Markdown
Contributor

petebacondarwin commented Dec 9, 2015

@IgorMinar do we need to update the changelog generator for this?

@IgorMinar
Copy link
Copy Markdown
Contributor Author

IgorMinar commented Dec 9, 2015

Not really. Most of the build commits are not interesting fior app
developers
On Wed, Dec 9, 2015 at 12:13 AM Pete Bacon Darwin notifications@github.com
wrote:

@IgorMinar https://github.com/IgorMinar do we need to update the
changelog generator for this?

—
Reply to this email directly or view it on GitHub
#5720 (comment).

@alexeagle alexeagle deleted the IgorMinar-patch-1-1 branch February 2, 2016 22:04
@angular-automatic-lock-bot
Copy link
Copy Markdown

angular-automatic-lock-bot bot commented Sep 7, 2019

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 7, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

@jelbourn jelbourn

Labels

action: merge The PR is ready for merge by the caretaker cla: yes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@IgorMinar @mary-poppins @petebacondarwin @jelbourn @googlebot
X Tutup