X Tutup
Skip to content

feat(TemplateParser): allow template elements regardless the namespace #5703

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
vicb wants to merge 1 commit into from
Closed

feat(TemplateParser): allow template elements regardless the namespace #5703

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion modules/angular2/src/compiler/template_parser.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@ import {Parser, AST, ASTWithSource} from 'angular2/src/core/change_detection/cha
import {TemplateBinding} from 'angular2/src/core/change_detection/parser/ast';
import {CompileDirectiveMetadata} from './directive_metadata';
import {HtmlParser} from './html_parser';
import {splitHtmlTagNamespace} from './html_tags';
import {ParseSourceSpan, ParseError, ParseLocation} from './parse_util';


Expand Down Expand Up @@ -215,7 +216,8 @@ class TemplateParseVisitor implements HtmlAstVisitor {
}
});

var isTemplateElement = nodeName.toLowerCase() == TEMPLATE_ELEMENT;
var lcElName = splitHtmlTagNamespace(nodeName.toLowerCase())[1];
var isTemplateElement = lcElName == TEMPLATE_ELEMENT;
var elementCssSelector = createElementCssSelector(nodeName, matchableAttrs);
var directives = this._createDirectiveAsts(
element.name, this._parseDirectives(this.selectorMatcher, elementCssSelector),
Expand Down
9 changes: 9 additions & 0 deletions modules/angular2/test/compiler/template_parser_spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -500,6 +500,15 @@ There is no directive with "exportAs" set to "dirA" ("<div [ERROR ->]#a="dirA"><
expect(humanizeTplAst(parse('<TEMPLATE></TEMPLATE>', [])))
.toEqual([[EmbeddedTemplateAst]]);
});

it('should create embedded templates for <template> elements regardless the namespace',
() => {
expect(humanizeTplAst(parse('<svg><template></template></svg>', [])))
.toEqual([
[ElementAst, '@svg:svg'],
[EmbeddedTemplateAst],
]);
});
});

describe('inline templates', () => {
Expand Down
X Tutup