Closed
Conversation
vicb
added
feature
Contributor
|
I am not in favor of this. The real solution is to integrate the html parser with the expression parser. Then we know when an expression starts and when it ends, and don't get confused whether a |
tbosch
added
pr_state: LGTM
action: cleanup
Contributor
Author
vicb
added
action: merge
Closed
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As reported in #5550,
{{ a < b ? c : d }}would throw because the lexer interpret "<" as the start of an element.While the error is legit according to HTML specs, replacing
<with>would be ugly in angular expression.This use case is probable with Angular and browsers would handle it. This PR makes the lexer more lenient and
<...is now interpreted as a text node when it would otherwise start a malformed start tag.A drawback is that some other error cases could not be reported any more, see the updates in the spec file for more info.
Notes:
<and the tag name</...because they are less likely to be part of an angular expression and Chrome would transform them to comments nodes./cc @yjbanov