X Tutup
Skip to content

Fix RxJS imports / relock RxJS version#5644

Closed
robwormald wants to merge 1 commit intoangular:masterfrom
robwormald:fix-rxjs-import
Closed

Fix RxJS imports / relock RxJS version#5644
robwormald wants to merge 1 commit intoangular:masterfrom
robwormald:fix-rxjs-import

Conversation

@robwormald
Copy link
Copy Markdown
Contributor

@robwormald robwormald commented Dec 6, 2015

closes #5643

@robwormald robwormald force-pushed the fix-rxjs-import branch 2 times, most recently from aa22632 to 3d15224 Compare December 6, 2015 02:19
@robwormald robwormald mentioned this pull request Dec 6, 2015
Closed
@robwormald robwormald added the action: review The PR is still awaiting reviews from at least one requested reviewer label Dec 6, 2015
@robwormald
Copy link
Copy Markdown
Contributor Author

robwormald commented Dec 6, 2015

cc @jeffbcross - i've relocked this back to .11 (which, incidentally, is not tagged on RxJS github..) - the changes in .12 introduce circular references which fail CI

@pkozlowski-opensource
Copy link
Copy Markdown
Member

pkozlowski-opensource commented Dec 7, 2015

@robwormald is alpha.11 is having rxjs/operators/toPromise; or rxjs/operator/toPromise; import? Looks like alpha.11 wasn't tagged so hard to check :-(

Asking since the title of your PR says "Fix RxJS imports" but I can't see any import changes, only version lock

@pkozlowski-opensource pkozlowski-opensource mentioned this pull request Dec 7, 2015
Closed
@jeffbcross jeffbcross added pr_state: LGTM action: merge The PR is ready for merge by the caretaker labels Dec 7, 2015
@jeffbcross jeffbcross assigned jelbourn and unassigned jeffbcross Dec 7, 2015
@jelbourn jelbourn added zomg_admin: do merge and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Dec 7, 2015
@mary-poppins
Copy link
Copy Markdown

mary-poppins commented Dec 7, 2015

Merging PR #5644 on behalf of @jelbourn to branch presubmit-jelbourn-pr-5644.

@jelbourn jelbourn closed this in 4b1618c Dec 7, 2015
robwormald added a commit to robwormald/angular that referenced this pull request Dec 7, 2015
@robwormald
fix(package): relock RxJS to alpha.11
9d8f6b1 
fixes angular#5643

Closes angular#5644
@angular-automatic-lock-bot
Copy link
Copy Markdown

angular-automatic-lock-bot bot commented Sep 7, 2019

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 7, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

@jelbourn jelbourn

Labels

action: merge The PR is ready for merge by the caretaker cla: yes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Bad rxjs import in facade/async.js

6 participants

@robwormald @pkozlowski-opensource @mary-poppins @jeffbcross @jelbourn @googlebot
X Tutup