upgrade rxjs dependency and implement pure operators#5626
Closed
jeffbcross wants to merge 1 commit intoangular:masterfrom
Closed
upgrade rxjs dependency and implement pure operators#5626jeffbcross wants to merge 1 commit intoangular:masterfrom
jeffbcross wants to merge 1 commit intoangular:masterfrom
Conversation
…e effects BREAKING CHANGE: toPromise is no longer an instance method of the `Observable` returned by Angular, and fromPromise is no longer available as a static method. The easiest way to account for this change in applications is to import the auto-patching modules from rxjs, which will automatically add these operators back to the Observable prototype. ``` import 'rxjs/add/operator/toPromise'; import 'rxjs/add/observable/fromPromise'; ``` Closes angular#5542
jeffbcross
force-pushed
the
toPromise2
branch
from
6294304 to
0383dbf
Compare
jeffbcross
added
the
action: review
jeffbcross
changed the title
jeffbcross
added
action: merge
Contributor
Author
|
LGTM is on the original PR #5623 Only difference in this PR is updating the RxJS version to latest. |
|
Merging PR #5626 on behalf of @jelbourn to branch presubmit-jelbourn-pr-5626. |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…e effects
BREAKING CHANGE:
toPromise is no longer an instance method of the
Observablereturnedby Angular, and fromPromise is no longer available as a static method.
The easiest way to account for this change in applications is to import
the auto-patching modules from rxjs, which will automatically add these
operators back to the Observable prototype.
Closes #5542