refactor(http): rename enums to be singular#5584
Closed
cexbrayat wants to merge 1 commit intoangular:masterfrom
Closed
refactor(http): rename enums to be singular#5584cexbrayat wants to merge 1 commit intoangular:masterfrom
cexbrayat wants to merge 1 commit intoangular:masterfrom
Conversation
Contributor
|
Looks good! Would you mind adding a colon after |
ReadyStates -> ReadyState RequestMethods -> RequestMethod ResponseTypes -> ResponseType Fixes angular#5574 BREAKING CHANGE: Before import {ReadyStates, RequestMethods, ResponseTypes} from 'angular2/http'; After import {ReadyState, RequestMethod, ResponseType} from 'angular2/http';
cexbrayat
force-pushed
the
refactor/http-enums
branch
from
29885ee to
22d4896
Compare
Member
Author
|
OK, it's done! |
Contributor
|
@jelbourn mind merging this? It will be a no-op for sync. |
Contributor
|
Thankx @cexbrayat! |
|
Merging PR #5584 on behalf of @jelbourn to branch presubmit-jelbourn-pr-5584. |
|
Merging PR #5584 on behalf of @jelbourn to branch presubmit-jelbourn-pr-5584. |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As seen with @jeffbcross in #5574
ReadyStates -> ReadyState
RequestMethods -> RequestMethod
ResponseTypes -> ResponseType